Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
AntonioVentilii-DFINITY pushed 1 commit to main dfinity/oisy-wallet
- feat(frontend): Include balances in token group (#3062) # Motivation Another useful PR for grouping tokens: we ne... 605c550
AntonioVentilii-DFINITY deleted a branch dfinity/oisy-wallet
feat(frontend)/Include-balances-in-token-group
AntonioVentilii-DFINITY closed a pull request on dfinity/oisy-wallet
feat(frontend): Include balances in token group
# Motivation Another useful PR for grouping tokens: we need to have the balances (both token and USD) for each group. Note that for nullish values for both tokens in group, we keep them as they ...
AntonioVentilii-DFINITY pushed 6 commits to feat(frontend)/Card-component-for-Token-Group dfinity/oisy-wallet
- feat(frontend): Use Network wallets for Onramper Widget (#2833) # Motivation As Security review suggested, it is ... 2e014c5
- fix(ci): fix run-name and remove ic (#3059) # Motivation We don't need the workflow to deploy to ic, since we do ... 0ba903d
- feat(frontend): network icon black white for receive (#3064) # Motivation The network icon displayed in the recei... 9fb3226
- feat(frontend): receive modal title with symbol (#3036) # Motivation The designers want to display the token symb... 31612ac
- feat(frontend): enhance dapp data (#3063) # Motivation The Design-Team added more social links and new images for... 885772a
- Merge branch 'main' into feat(frontend)/Card-component-for-Token-Group d502215
AntonioVentilii-DFINITY pushed 7 commits to feat(frontend)/Include-balances-in-token-group dfinity/oisy-wallet
- feat(frontend): Introduce OisySymbol prop for appearence interface (#3053) # Motivation For grouping tokens, we a... 51609a5
- feat(frontend): Use Network wallets for Onramper Widget (#2833) # Motivation As Security review suggested, it is ... 2e014c5
- fix(ci): fix run-name and remove ic (#3059) # Motivation We don't need the workflow to deploy to ic, since we do ... 0ba903d
- feat(frontend): network icon black white for receive (#3064) # Motivation The network icon displayed in the recei... 9fb3226
- feat(frontend): receive modal title with symbol (#3036) # Motivation The designers want to display the token symb... 31612ac
- feat(frontend): enhance dapp data (#3063) # Motivation The Design-Team added more social links and new images for... 885772a
- Merge branch 'main' into feat(frontend)/Include-balances-in-token-group bd2df08
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
I just meant: - Should a button be disabled when it is set as "loading"? - Can a button be set as "disabled" and "loading" at the same time?
loki344 created a comment on a pull request on dfinity/oisy-wallet
Or.. use a existing library instead..? https://www.embla-carousel.com/examples/predefined/#auto-scroll
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Makes sense, thanks for the explanation.
loki344 created a comment on a pull request on dfinity/oisy-wallet
maybe take a look at: https://svelte.dev/playground/c379be902322415bb1e10f855442f40a?version=4.2.1 Seems to use transform magic
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
i wanted to do it at usage level: you mean to set the logic here right? If `loading` then `disabled` for sure?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
btw. can a button be set as disabled and loading at the same time?
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
Good question... The only issue I see is to keep it consistent with definition of `TokenUi.usdBalance` that can be either `number` or `undefined`, but not `null`. When it is `undefined`, we s...
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
For consistency with `sumTokenBalances`, shouldn't `sumTokenUsdBalances` returns `null` then if both tokens are `undefined`? Or should the function always returns a zero or value, hence suggesti...
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
I oversaw it, good point.
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Yes, works for me.
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Nvm my comment, my bad.
AntonioVentilii-DFINITY created a review on a pull request on dfinity/oisy-wallet
I think there was a misunderstanding: your first iteration was ok, I would have just used the `initCertifiedSetterStore` So, that the definition would have been ```typescript export interfac...
loki344 created a review comment on a pull request on dfinity/oisy-wallet
Sorry ,I don't understand your question.
loki344 pushed 4 commits to feat(frontend)/enhance-dapp-modal dfinity/oisy-wallet
- feat(frontend): network icon black white for receive (#3064) # Motivation The network icon displayed in the recei... 9fb3226
- feat(frontend): receive modal title with symbol (#3036) # Motivation The designers want to display the token symb... 31612ac
- feat(frontend): enhance dapp data (#3063) # Motivation The Design-Team added more social links and new images for... 885772a
- Merge remote-tracking branch 'origin/main' into feat(frontend)/enhance-dapp-modal # Conflicts: # src/frontend/src/li... b9df8bc
loki344 pushed 1 commit to main dfinity/oisy-wallet
- feat(frontend): enhance dapp data (#3063) # Motivation The Design-Team added more social links and new images for... 885772a