Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
loki344 closed a pull request on dfinity/oisy-wallet
feat(frontend): enhance dapp data
# Motivation The Design-Team added more social links and new images for the dapp-explorer. This MR updates adds the new data. # Changes - Add images for decideID and OpenChat - New image ...loki344 pushed 3 commits to feat(frontend)/enhance-dapp-description dfinity/oisy-wallet
- feat(frontend): network icon black white for receive (#3064) # Motivation The network icon displayed in the recei... 9fb3226
- feat(frontend): receive modal title with symbol (#3036) # Motivation The designers want to display the token symb... 31612ac
- Merge branch 'main' into feat(frontend)/enhance-dapp-description 77c5e4e
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Cool
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
not for this PR but, I guess this can become `true` actually?
AntonioVentilii-DFINITY opened a pull request on dfinity/oisy-wallet
feat(frontend): Add loading style to Button component
# Motivation We want to display "loading" buttons in the Hero, similar to a Skeleton, but resembling the pulsating effect of the balance on loading. So, as first step, we add `loading` prop t...AntonioVentilii-DFINITY created a branch on dfinity/oisy-wallet
feat(frontend)/Add-loading-style-to-ButtonComponent - A browser-based, multi-chain wallet hosted on the Internet Computer
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
I have a few tests to check the different returns for `null` and `undefined`
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
I defined the return type as `TokenUi['balance']` which definition is ![Screenshot 2024-10-23 at 13 24 26](https://github.com/user-attachments/assets/159de022-3e1f-49cb-8770-886074da3b76)
AntonioVentilii-DFINITY pushed 1 commit to feat(frontend)/Include-balances-in-token-group dfinity/oisy-wallet
- refactor: simplify sumTokenUsdBalances 9922c6a
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
you are right! I was already thinking about multiple tokens in the group! Changed to `[TokenUi, TokenUi]` that should act as guard too, no?
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
it will be added in both cases, so it will stay the same as the other. I didn't put the check for a zero balance, do you think it is necessary? Meaning, either way, summing 0 is ok no?
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
i would prefer to leave `undefined` if both are `undefined`
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
ah! make sense what about this? ```typescript export const sumTokenUsdBalances = ([token1, token2]: TokenUi[]): TokenUi['usdBalance'] => nonNullish(token1.usdBalance) || nonNullish(token2.usd...
loki344 created a comment on a pull request on dfinity/oisy-wallet
> Could you confirm if the new PNG files are optimized for the best resolution and compression? For example, woould similar files in Webp significantly smaller? Converting to webp and compressin...
loki344 pushed 1 commit to feat(frontend)/enhance-dapp-description dfinity/oisy-wallet
- feat(frontend): omptimize images afbd74b
darioloetsc opened a pull request on dfinity/oisy-wallet
feat(frontend): simple token group store
# Motivation Introduce a token group store to preserve expanded settings in the grouping view. # Changes Add token group store. # Testsloki344 pushed 1 commit to feat(frontend)/enhance-dapp-description dfinity/oisy-wallet
- feat(frontend): revert unwanted change dcbb9bd
DenysKarmazynDFINITY created a comment on a pull request on dfinity/oisy-wallet
@peterpeterparker sure, this is the PR with the Carousel component - https://github.com/dfinity/oisy-wallet/pull/3069. There will be one more with a small adjustments to the already merged Indicato...
darioloetsc created a branch on dfinity/oisy-wallet
feat(frontend)/simple-token-group-store - A browser-based, multi-chain wallet hosted on the Internet Computer