Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
AntonioVentilii-DFINITY created a branch on dfinity/oisy-wallet
feat(frontend)/Add-loading-style-to-ButtonComponent - A browser-based, multi-chain wallet hosted on the Internet Computer
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
I have a few tests to check the different returns for `null` and `undefined`
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
I defined the return type as `TokenUi['balance']` which definition is 
AntonioVentilii-DFINITY pushed 1 commit to feat(frontend)/Include-balances-in-token-group dfinity/oisy-wallet
- refactor: simplify sumTokenUsdBalances 9922c6a
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
you are right! I was already thinking about multiple tokens in the group! Changed to `[TokenUi, TokenUi]` that should act as guard too, no?
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
it will be added in both cases, so it will stay the same as the other. I didn't put the check for a zero balance, do you think it is necessary? Meaning, either way, summing 0 is ok no?
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
i would prefer to leave `undefined` if both are `undefined`
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
ah! make sense what about this? ```typescript export const sumTokenUsdBalances = ([token1, token2]: TokenUi[]): TokenUi['usdBalance'] => nonNullish(token1.usdBalance) || nonNullish(token2.usd...
loki344 created a comment on a pull request on dfinity/oisy-wallet
> Could you confirm if the new PNG files are optimized for the best resolution and compression? For example, woould similar files in Webp significantly smaller? Converting to webp and compressin...
loki344 pushed 1 commit to feat(frontend)/enhance-dapp-description dfinity/oisy-wallet
- feat(frontend): omptimize images afbd74b
darioloetsc opened a pull request on dfinity/oisy-wallet
feat(frontend): simple token group store
# Motivation Introduce a token group store to preserve expanded settings in the grouping view. # Changes Add token group store. # Tests
loki344 pushed 1 commit to feat(frontend)/enhance-dapp-description dfinity/oisy-wallet
- feat(frontend): revert unwanted change dcbb9bd
DenysKarmazynDFINITY created a comment on a pull request on dfinity/oisy-wallet
@peterpeterparker sure, this is the PR with the Carousel component - https://github.com/dfinity/oisy-wallet/pull/3069. There will be one more with a small adjustments to the already merged Indicato...
darioloetsc created a branch on dfinity/oisy-wallet
feat(frontend)/simple-token-group-store - A browser-based, multi-chain wallet hosted on the Internet Computer
DenysKarmazynDFINITY opened a pull request on dfinity/oisy-wallet
feat(frontend): Carousel component
# Motivation This PR includes the main Carousel component. It is based on the Carouse-utils branch, it will be switched to `main` after that PR is merged. https://github.com/user-attachme...
loki344 pushed 1 commit to feat(frontend)/enhance-dapp-description dfinity/oisy-wallet
- feat(frontend): extend existing interface to extract oisy specific fields 2d6bb3c
peterpeterparker pushed 1 commit to feat/copy-block-receive-address dfinity/oisy-wallet
- feat: spacing and text for later fe2eb07
DenysKarmazynDFINITY created a branch on dfinity/oisy-wallet
feat(frontend)/carousel-component - A browser-based, multi-chain wallet hosted on the Internet Computer
peterpeterparker pushed 1 commit to feat/copy-block-receive-address dfinity/oisy-wallet
- feat: display or not qr code button cb9c1f8
peterpeterparker created a comment on a pull request on dfinity/oisy-wallet
Feels like we should bump Svelte v5 so that you resolve this with the new `Snippet` pattern. Do you have a WIP branch to share in which those utils are used? Just to grasp a better sense of how ...
darioloetsc created a comment on a pull request on dfinity/oisy-wallet
will split in two, and refactoring is bigger than expected
darioloetsc closed a pull request on dfinity/oisy-wallet
feat(frontend): add token group store
# Motivation Introduce a token group store to preserve expanded settings in the grouping view. # Changes - Add token group store # Tests