Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
DenysKarmazynDFINITY created a comment on a pull request on dfinity/oisy-wallet
@peterpeterparker also a valid question, and it was my initial intention to do so, but it appeared it's not possible to work with `slots` in Svelte similar to `React.children`: looping through them...
peterpeterparker created a comment on a pull request on dfinity/oisy-wallet
Thanks for the explanation. I then have a follow-up question: why manipulating the DOM manually and not resolving the implementation using Svelte? Fortunatelly Svelte has not virtual DOM but, I'...
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
same question for usd
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Does it really matter here? It's all dollars, shouldn't the array just be reduced to sum all usd balance?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
what if token2 balance is zero but token1 balance is >0 ?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
- Should we add a guard if there are more than two tokens? - If exactly two tokens, should the array be actually typed as `[TokenUi, TokenUi]`?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Maybe I'm misleading it but,`null` is maybe not specified as return type of the function?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
definitely another PR, thanks
DenysKarmazynDFINITY created a comment on a pull request on dfinity/oisy-wallet
@peterpeterparker yes, the CSS approach was my first thought, but, unfortunately, it doesn't align with the requirements for the wanted carousel component. To name a few reasons why we do need to m...
peterpeterparker pushed 1 commit to feat/copy-block-receive-address dfinity/oisy-wallet
- fix: merge error 04320ef
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
right! make sense! can i do it in another PR? because I am pretty sure it will change some other components and should be indeed a different topic
AntonioVentilii-DFINITY pushed 1 commit to feat(frontend)/Include-balances-in-token-group dfinity/oisy-wallet
- chore: adjust string fdf27b7
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
- done! and created test - good catch! I completely missed that... - see first point please review it again, because i separated the smaller functions and created tests about it
peterpeterparker pushed 3 commits to feat/copy-block-receive-address dfinity/oisy-wallet
- feat(frontend): network icon black white for receive (#3064) # Motivation The network icon displayed in the recei... 9fb3226
- feat(frontend): receive modal title with symbol (#3036) # Motivation The designers want to display the token symb... 31612ac
- Merge branch 'main' into feat/copy-block-receive-address 35906e0
peterpeterparker pushed 1 commit to main dfinity/oisy-wallet
- feat(frontend): receive modal title with symbol (#3036) # Motivation The designers want to display the token symb... 31612ac
peterpeterparker closed a pull request on dfinity/oisy-wallet
feat(frontend): receive modal title with symbol
# Motivation The designers want to display the token symbol within the "Receive" modal title. # Changes - Since `addressToken` is per definition potentially `undefined` either just display...
peterpeterparker pushed 2 commits to feat/receive-modal-title dfinity/oisy-wallet
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
given that `DappDescription` matches the types of the portal and II, can you rather add the new specific fields for Oisy as extension? For example: interface DappDescription {} interface Ois...
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
Could you confirm if the new PNG files are optimized for the best resolution and compression? For example, woould similar files in Webp significantly smaller?
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
Could you confirm if the new PNG files are optimized for the best resolution and compression? For example, woould similar files in Webp significantly smaller?
AntonioVentilii-DFINITY pushed 1 commit to feat(frontend)/Include-balances-in-token-group dfinity/oisy-wallet
- refactor: extract sum functions 37d2ddc
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
Before reviewing the code: have you considered other approaches that does not require manipulating the DOM and calculating width, such as using CSS scroll snap?
darioloetsc created a review comment on a pull request on dfinity/oisy-wallet
No, symbol cannot be persisted in local storage. The CertifiedSetterStore seems not to store to local storage and be implemented on TokenId (symbol).
darioloetsc pushed 1 commit to feat(frontend)/token-grouping-store dfinity/oisy-wallet
- feat(frontend): format d4fb547