Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
peterpeterparker pushed 2 commits to feat/receive-modal-title dfinity/oisy-wallet
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
given that `DappDescription` matches the types of the portal and II, can you rather add the new specific fields for Oisy as extension? For example: interface DappDescription {} interface Ois...
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
Could you confirm if the new PNG files are optimized for the best resolution and compression? For example, woould similar files in Webp significantly smaller?
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
Could you confirm if the new PNG files are optimized for the best resolution and compression? For example, woould similar files in Webp significantly smaller?
AntonioVentilii-DFINITY pushed 1 commit to feat(frontend)/Include-balances-in-token-group dfinity/oisy-wallet
- refactor: extract sum functions 37d2ddc
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
Before reviewing the code: have you considered other approaches that does not require manipulating the DOM and calculating width, such as using CSS scroll snap?
darioloetsc created a review comment on a pull request on dfinity/oisy-wallet
No, symbol cannot be persisted in local storage. The CertifiedSetterStore seems not to store to local storage and be implemented on TokenId (symbol).
darioloetsc pushed 1 commit to feat(frontend)/token-grouping-store dfinity/oisy-wallet
- feat(frontend): format d4fb547
peterpeterparker created a comment on a pull request on dfinity/oisy-wallet
> The proposed so it originally needed to be a draft, I see. thanks for the feedback.
peterpeterparker pushed 1 commit to main dfinity/oisy-wallet
- feat(frontend): network icon black white for receive (#3064) # Motivation The network icon displayed in the recei... 9fb3226
peterpeterparker closed a pull request on dfinity/oisy-wallet
feat(frontend): network icon black white for receive
# Motivation The network icon displayed in the receive modals should be black and white according Figma.
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
so, shouldn't it be called `TokenUiGroup`?
darioloetsc created a comment on a pull request on dfinity/oisy-wallet
@peterpeterparker—The proposed store needs to be made generic. The 19 additional changed files are type adjustments.
peterpeterparker created a comment on a pull request on dfinity/oisy-wallet
Why is there suddently 19 files modified in this PR when it was first provided with a single file change? Is this a draft?
loki344 pushed 3 commits to feat(frontend)/enhance-dapp-description dfinity/oisy-wallet
- Revert "feat(frontend): enhance information and styling in dappmodal" This reverts commit ded6101f6cf30d5ae0ff2d0a62... 6d2702f
- Revert "feat(frontend): add alt texts for telegram and openchat, modify open dapp text" This reverts commit 2aea96b6... ecc1f01
- Revert "feat(frontend): add social icons for telegram and openchat" This reverts commit 23da3bc5b64f84acda945623a2d3... 8f012e8
inc-man created a review comment on a pull request on dfinity/oisy-wallet
you are absolutely correct. I did not read the create-pr action correctly. Removed everything that is not necessary.
inc-man pushed 1 commit to fix(ci)/fix-release-process dfinity/oisy-wallet
- remove unnecessary tasks fe87341
loki344 pushed 19 commits to feat(frontend)/enhance-dapp-description dfinity/oisy-wallet
- feat(frontend): Carousel Controls components (#3046) # Motivation This PR includes Carousel Controls component. ... 5331e4d
- feat(frontend): add menu for dapp explorer (#3047) # Motivation The Dapp explorer is missing in the mobile naviga... 4e0396f
- chore(e2e): Update Playwright E2E Snapshots (#3049) The following E2E snapshots have been updated: ``` e2e/homepag... 98d1a3b
- feat(frontend): remove header Back (#3048) # Motivation The new route behavior `/explore` introduced an inconsist... 7a6bd36
- feat(frontend): review address block (#3013) # Motivation We want to redesign a bit the address we present in mod... ebbe821
- feat(frontend): display token as logo above qr-code (#3023) # Motivation The designers want to display the token ... 224f2de
- chore(e2e): Update Playwright E2E Snapshots (#3056) The following E2E snapshots have been updated: ``` e2e/receive... 5520de2
- test(frontend): Add test ID for token group in TokenCard (#3052) # Motivation The component `TokenCard` will be r... 696ce03
- refactor(build): Change tailwind config to Typescript (#3051) # Motivation Just to use more Typescript, we change... d74de9a
- feat(frontend): Remove redundant prop to show back button in Hero (#3055) # Motivation The `Back` button showed i... 1559078
- refactor(frontend): Include native token in token group property (#3043) # Motivation It is useful to have the na... 875f219
- chore(frontend): format i18n type file (#3050) # Motivation Maybe in some PR, an unformatted `i18n` type file sli... e2c6553
- feat(frontend): Provide token count in Token logo (#3041) # Motivation For PR #3028, to group tokens, we want to ... 68d7756
- refactor(frontend): extract qr code address content component (#3058) # Motivation Two components that display a ... 8ccc407
- feat(frontend): qr code min height to prevent modal glitch (#3057) # Motivation The QR code has no minimum height... f83f883
- feat(frontend): Introduce OisySymbol prop for appearence interface (#3053) # Motivation For grouping tokens, we a... 51609a5
- feat(frontend): Use Network wallets for Onramper Widget (#2833) # Motivation As Security review suggested, it is ... 2e014c5
- fix(ci): fix run-name and remove ic (#3059) # Motivation We don't need the workflow to deploy to ic, since we do ... 0ba903d
- Merge remote-tracking branch 'origin/main' into feat(frontend)/enhance-dapp-description # Conflicts: # src/frontend/... 66b4c68
loki344 pushed 1 commit to feat(frontend)/enhance-dapp-modal dfinity/oisy-wallet
- feat(frontend): format 937f39c
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
it is to indicate that the group contains TokenUi and not just Token: in fact it should be used only in UI context (appearance, show the list, etc)
loki344 pushed 19 commits to feat(frontend)/enhance-dapp-modal dfinity/oisy-wallet
- feat(frontend): Carousel Controls components (#3046) # Motivation This PR includes Carousel Controls component. ... 5331e4d
- feat(frontend): add menu for dapp explorer (#3047) # Motivation The Dapp explorer is missing in the mobile naviga... 4e0396f
- chore(e2e): Update Playwright E2E Snapshots (#3049) The following E2E snapshots have been updated: ``` e2e/homepag... 98d1a3b
- feat(frontend): remove header Back (#3048) # Motivation The new route behavior `/explore` introduced an inconsist... 7a6bd36
- feat(frontend): review address block (#3013) # Motivation We want to redesign a bit the address we present in mod... ebbe821
- feat(frontend): display token as logo above qr-code (#3023) # Motivation The designers want to display the token ... 224f2de
- chore(e2e): Update Playwright E2E Snapshots (#3056) The following E2E snapshots have been updated: ``` e2e/receive... 5520de2
- test(frontend): Add test ID for token group in TokenCard (#3052) # Motivation The component `TokenCard` will be r... 696ce03
- refactor(build): Change tailwind config to Typescript (#3051) # Motivation Just to use more Typescript, we change... d74de9a
- feat(frontend): Remove redundant prop to show back button in Hero (#3055) # Motivation The `Back` button showed i... 1559078
- refactor(frontend): Include native token in token group property (#3043) # Motivation It is useful to have the na... 875f219
- chore(frontend): format i18n type file (#3050) # Motivation Maybe in some PR, an unformatted `i18n` type file sli... e2c6553
- feat(frontend): Provide token count in Token logo (#3041) # Motivation For PR #3028, to group tokens, we want to ... 68d7756
- refactor(frontend): extract qr code address content component (#3058) # Motivation Two components that display a ... 8ccc407
- feat(frontend): qr code min height to prevent modal glitch (#3057) # Motivation The QR code has no minimum height... f83f883
- feat(frontend): Introduce OisySymbol prop for appearence interface (#3053) # Motivation For grouping tokens, we a... 51609a5
- feat(frontend): Use Network wallets for Onramper Widget (#2833) # Motivation As Security review suggested, it is ... 2e014c5
- fix(ci): fix run-name and remove ic (#3059) # Motivation We don't need the workflow to deploy to ic, since we do ... 0ba903d
- Merge branch 'refs/heads/main' into feat(frontend)/enhance-dapp-modal # Conflicts: # src/frontend/src/lib/types/i18n... 53112ed
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
is the step `Commit version bump on release` branch needed? I think the `create-pr` action already takes care of everything, no? At least, it does it in the other workflows: have a look at `Remove ...
darioloetsc pushed 1 commit to feat(frontend)/token-grouping-store dfinity/oisy-wallet
- feat(frontend): make generic id interface for storage 40b801c
loki344 opened a draft pull request on dfinity/oisy-wallet
feat(frontend): enhance dapp modal
# Motivation Integrate testing feedback: More social links, styling issue of image on small screens. # Changes - Integrate new social links with icons. - Fix Image height before: <...