Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
DanielSchiavini created a review comment on a pull request on curvefi/curve-frontend
`gaugeStatus.queryKey({...})`
DanielSchiavini closed a draft pull request on curvefi/curve-frontend
feat: show pool list without RPC connection
- Show the pool list even if there is no RPC available - Initialize dependencies even if no RPC is available - CurveJS depends on https://github.com/curvefi/curve-js/pull/394 - CurveStableCo...
DanielSchiavini created a review comment on a pull request on curvefi/curve-frontend
If I run `npm run format` I get 244 files changed
DanielSchiavini created a review comment on a pull request on curvefi/curve-frontend
seems it's not part of the pipeline
DanielSchiavini created a review comment on a pull request on curvefi/curve-frontend
so the pageProps are defined globally, but in this case we know the market is set, so it's safe to use `!` however, it would be best to refactor and remove market from pageProps
DanielSchiavini created a review comment on a pull request on curvefi/curve-frontend
this will not return undefined, it would throw an error if api is undefined. However, the enabled condition checks for the API being in the store
DanielSchiavini created a review comment on a pull request on curvefi/curve-frontend
yeah this looks incorrect
ignromanov created a review comment on a pull request on curvefi/curve-frontend
```suggestion markets: ({ chainId }: ChainQueryParams) => [...chainKeys.root({ chainId }), 'markets'] as const, ```
ignromanov created a review comment on a pull request on curvefi/curve-frontend
Good to add type to the marketName
ignromanov created a review comment on a pull request on curvefi/curve-frontend
Put jsdoc `@deprecated` tag or something like this. To don't use it and don'd forget to delete in a future.
ignromanov created a review comment on a pull request on curvefi/curve-frontend
You cannot return undefined from queries. Throw an error if `api` doesn't exists
ignromanov created a review comment on a pull request on curvefi/curve-frontend
I would name it `markets-query`
ignromanov created a review comment on a pull request on curvefi/curve-frontend
```suggestion const { data: marketMapping } = useOneWayMarketMapping(rChainId) ``` What's wrong with prettier?
ignromanov created a review comment on a pull request on curvefi/curve-frontend
Why can a hook be undefined? 🤔
ignromanov created a review comment on a pull request on curvefi/curve-frontend
How can we use this key from outside? To pass it to `dependencies` for example
ignromanov created a review comment on a pull request on curvefi/curve-frontend
```suggestion const isEnabled = (params: TParams) => checkValidity(validationSuite, params) && !dependencies?.(params). some(key => !queryClient.getQueryData(key)) ``` looks better
ignromanov created a review comment on a pull request on curvefi/curve-frontend
I would put it to the `shared/model/query/`
OnlyJousting deleted a branch curvefi/curve-frontend
task/external-rewards-add-pools-for-etherfi,lombard-and-fraxtal-campaigns
