Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
github-advanced-security[bot] created a review comment on a pull request on containerbuildsystem/cachi2
## Unnecessary pass Unnecessary 'pass' statement. [Show more details](https://github.com/containerbuildsystem/cachi2/security/code-scanning/231)
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
I have not checked yet, but I have a strong suspicion that this would break the existing pattern. Refactoring half of PMs is definitely not in scope, so we likely can keep it as is for now.
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
Actually it seems like we have overthought this. The following code should do the trick: ```python from abc import ABC, abstractmethod ConfigTypes = Literal["package_json", "yarnrc", "yarnlock"]...
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
From a purist's perspective we should be raising ParsingError here which must be converted to PackageRejected at caller's level. I am not a purist and won't block on this.
ben-alkov created a review comment on a pull request on containerbuildsystem/cachi2
'.yarnrc' and 'package.json' both have `write()` methods in cachi2's Yarnberry implementation.
ben-alkov created a review comment on a pull request on containerbuildsystem/cachi2
I see what you're saying; this is the pattern I copied from Yarnberry. If we have an error parsing any config file *for the current package*, we can't continue, so `PackageRejected` is appropriate....
ben-alkov created a review comment on a pull request on containerbuildsystem/cachi2
Nice! I need to get more familiar with `Path`...
ben-alkov created a review comment on a pull request on containerbuildsystem/cachi2
@a-ovchinnikov; As always, the Devil is in the (typing) details... ``` cachi2/core/package_managers/yarn_classic/project.py:68: error: Signature of "_self_type" incompatible with supertype "_Co...
ben-alkov created a review comment on a pull request on containerbuildsystem/cachi2
thinking: That's nice
arewm opened an issue on containerbuildsystem/cachi2
Cachi2 prefetching for gomod is making changes on the source.
When running Cach2 on a source repo with the gomod package manager, changes are made to the `go.mod` file. This is presumably from running `go mod tidy`. Cachi2 should not modify the sources tha...
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
```suggestion package_json_data = json.loads(path.path.read_text()) ```
a-ovchinnikov created a review on a pull request on containerbuildsystem/cachi2
A few minor suggestions and some questions.
a-ovchinnikov created a review on a pull request on containerbuildsystem/cachi2
A few minor suggestions and some questions.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
> I don't think this is true. Cachi2 is quite literally in control of how much validation it does. It does not have to take the purl verbatim, it is free to decompose it into individual attributes ...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
We used an explicit env because we were calling into the Yarn cmd executor wrapper directly. That is now abstracted by the new version parser helper and so the helper can hardcode this bit, no need...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
I may not have been very clear on this especially using the whole hunk as context. Admittedly, there was a slight oversight on my side regarding the version mismatch check which stays in this funct...