Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
Yes, I messed that up during splitting of the commits, I meant to edit the below error. Let me fix that.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
This should have happened in the same commit as the other error type fix. To minimize the rebase conflicts and changes in general, please move the last commit to the very beginning of the series t...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
You revert this hunk in the last commit. Sounds like a rebase typo.
eskultety created a review on a pull request on containerbuildsystem/cachi2
Last minor comments, quick respin will do -> ACK.
eskultety created a review on a pull request on containerbuildsystem/cachi2
Last minor comments, quick respin will do -> ACK.
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
I would have written it as `other'` if Python allowed me to, I have spelled `'` out without thinking twice. I'll update to `other_ver` to make this look less surprising. _Edit_: `öther` is a tempti...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
This code extraction should be a separate commit.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
nitpick: `packaging.Version` is different from `semver.Version`. We do use **a** `Version` object interchangeably throughout the code base IIRC so a type name of `SemVerLike` feels more appropriate...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
nitpick: what is the meaning of "prime" here? I'm a bit lost in translation; wouldn't `other_ver` be less linguistically challenging :)?
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
This was intentional and I'd argue that it's even correct since RCs are like ~90% of the final release and so if we're not ready for the next major we can't be ready even for the the RC in terms of...
eskultety created a review on a pull request on containerbuildsystem/cachi2
Nitpicks only, quick respin will do!
eskultety created a review on a pull request on containerbuildsystem/cachi2
Nitpicks only, quick respin will do!
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
> i.e. consuming user input with little to no validation and use it for output generation (in this case taking the PURL verbatim) and as such tainting is undesirable in general and so we'd like to ...
aloubyansky created a review comment on a pull request on containerbuildsystem/cachi2
```suggestion "purl": "pkg:maven/io.quarkus/[email protected]?type=jar&repository_url=https://maven.repository.internal.com/ga&checksums=sha1:e4ca5fadf89e62fb29d0d00804...
kosciCZ created a comment on a pull request on containerbuildsystem/cachi2
@brunoapimentel @eskultety If you don't have any outstanding comments, please approve & merge. Thanks!
eskultety closed a pull request on containerbuildsystem/cachi2
bug: Don't skip integration tests on Dockerfile change
The logic for skipping integration tests also skipped them when Dockerfile is changed. This commit adds Dockerfile (and Containerfile just in case) to the list of locations that must be tested. ...
github-merge-queue[bot] pushed 1 commit to main containerbuildsystem/cachi2
- bug: Don't skip integration tests on Dockerfile change The logic for skipping integration tests also skipped them wh... 918c3d0
github-merge-queue[bot] deleted a branch containerbuildsystem/cachi2
gh-readonly-queue/main/pr-702-c96978b1df805fea8e464591090f6eaa7d45838d
github-merge-queue[bot] created a branch on containerbuildsystem/cachi2
gh-readonly-queue/main/pr-702-c96978b1df805fea8e464591090f6eaa7d45838d - Cachi2 is a CLI tool that pre-fetches your project's dependencies to aid in making your build process network-isolated.
aloubyansky created a review comment on a pull request on containerbuildsystem/cachi2
I wouldn't like to put extra burden on Cachi2 maintenance. So far, it seems to me this proposal creates more complexity than the alternative.