Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
Yes, we can default to a location within a repo and use defaut configuration mechanism, but would need a way to point to some external config which will be version-controlled elsewhere. Suppose som...
brunoapimentel created a review comment on a pull request on containerbuildsystem/cachi2
That is a good point. If we agree on enforcing the registry URL as a global rule for enhancing purls, we can probably drop this field.
slimreaper35 created a comment on a pull request on containerbuildsystem/cachi2
We have it for all e2e tests for all package managers, so at least for consistency, I would add it. We can discuss it when we put all integration tests into a single repo. That should be a good sta...
a-ovchinnikov created a comment on a pull request on containerbuildsystem/cachi2
> And how about the SBOM from e2e tests ? Do we need it? The logic of SBOM generation is pretty static and well-tested with UTs (97+% coverage is no joke). The tests check that bundler can build...
taylormadore created a review comment on a pull request on containerbuildsystem/cachi2
I think we'll just use/enhance the existing [config-file functionality](https://github.com/containerbuildsystem/cachi2?tab=readme-ov-file#configuration), right?
slimreaper35 closed a pull request on containerbuildsystem/cachi2
Makefile improvements
# Maintainers will complete the following section - [ ] Commit messages are descriptive enough - [ ] Code coverage from testing does not decrease and new code is covered - [ ] Docs updated (if...
slimreaper35 created a comment on a pull request on containerbuildsystem/cachi2
> If I read the link correctly this is a different platform: not a platform a gem is compiled to, but a Ruby implementation. The given example explicitly mentions JRuby. Okay. So we can probably...
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
What do you think about splitting the test in two: a positive and a negative test? ```python @mark.parametrize("url", ["https://foo.com/bar.tgz", ... ], ) def test__is_tarball_url_can_par...
a-ovchinnikov created a review on a pull request on containerbuildsystem/cachi2
Mostly LGTM, a couple of small nitpicks.
a-ovchinnikov created a review on a pull request on containerbuildsystem/cachi2
Mostly LGTM, a couple of small nitpicks.
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
> should be taken care of with an after model validator (as field validators must take attribute order validation into consideration and so are painful to deal with) OR maybe there's a callback for...
slimreaper35 created a review comment on a pull request on containerbuildsystem/cachi2
fixed description of all environment variables
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
We do parallel pretty much everywhere exactly due to reasons @kosciCZ mentions, so it's preferable and there's precedent -> marking as resolved.
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
It would, but I know that these lockfiles won't be small and could go up to a couple thousand. I think that having a little more complicated code to achieve parallel download is worth it in this case.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
nitpick: This should be a separate commit as it's a unrelated change fixing a wrong type of error used for the given scenario.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
I'd also add one with a complex download URL to test path extraction that is to serve as the target file name.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
nitpick: I think this commentary is redundant as we pretty much use `join_within_root` for this particular purpose across the whole code base.