Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
Thanks for the tip! Changed.
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
Removed entirely with the whole class.
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
Resolving. If you still disagree, or have further questions, feel free to unresolve.
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
Removed the `GenericArtifact` class, it was mostly redundant. I originally created it, because I did not want to mix validation and whatever happens next to the artifact. I've added `_resolved_pat...
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
Removed this class.
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
I used the general idea of this approach. Destination is now `_resolved_path` in the `LockfileArtifact`
a-ovchinnikov created a comment on a pull request on containerbuildsystem/cachi2
>> One more thing, that I probably mentioned somewhere, if we want to add platform qualifier in the PURLs: https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst#gem > Good point. ...
slimreaper35 created a review comment on a pull request on containerbuildsystem/cachi2
Can I use similar reasoning? > People should be aware of setup.py soft deprecation by now, do we want to hold everyone's hand? I mean displaying a warning for users who genuinely need setup.py (...
github-merge-queue[bot] pushed 1 commit to main containerbuildsystem/cachi2
- CONTRIBUTING: Adds PR comments handling rule to guideline Added a rule about responding to inline comments in PRs. S... 1d7bb86
a-ovchinnikov closed a pull request on containerbuildsystem/cachi2
CONTRIBUTING: Adds PR comments handling rule to guideline
Added a rule about responding to inline comments in PRs. Sometimes it takes additional effort to ensure that something was addressed. If this rule is present and respected then it would be easier t...
github-merge-queue[bot] deleted a branch containerbuildsystem/cachi2
gh-readonly-queue/main/pr-691-e64c2eb84ac6ca06922b9fd62a12f1434c23bb9d
github-merge-queue[bot] created a branch on containerbuildsystem/cachi2
gh-readonly-queue/main/pr-691-e64c2eb84ac6ca06922b9fd62a12f1434c23bb9d - Cachi2 is a CLI tool that pre-fetches your project's dependencies to aid in making your build process network-isolated.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
fair enough, works for me.
eskultety created a comment on a pull request on containerbuildsystem/cachi2
FYI I opened https://github.com/pydantic/pydantic/discussions/10670 to understand why `pydantic` has this fixed version lock on core breaking our CI on every scheduled dependabot sync.
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
"Done" + resolve could be an option. I think "done" or any other minimal-effort response is better than just resolving, at least for 3rd party contributors: this makes it obvious that they have rea...
eskultety created a comment on a pull request on containerbuildsystem/cachi2
> > > After having carefully gone through the unit tests which I didn't do in my first round of reviews I think we're actually opening us up for potential issues with pyproject.toml setup.py etc. m...