Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
I wonder if it isn't easier to encourage contributors to directly resolve the threads themselves **iff** they've addressed the comments and leave it open otherwise. Seems like a bit of an overkill ...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
**Commit subject**: s/meta/CONTRIBUTING meta doesn't IMO hint at anything when it comes to narrowing the context of the changes in the subject.
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
Added and moved into a separate test function that also builds the image.
brunoapimentel opened a pull request on containerbuildsystem/cachi2
Draft proposal: Enhanced purls for generic artifacts
This draft introduces a more generic alternative to solve the need for specific Maven purls covered in #663. In summary, it is a mechanism that would allow us to support a subset of [purl types...
a-ovchinnikov created a review on a pull request on containerbuildsystem/cachi2
Please squash commits that introduce and then update the same block. The change is at about 3k lines at this moment, it takes some time to navigate and review it. https://github.com/containerbui...
a-ovchinnikov opened a pull request on containerbuildsystem/cachi2
meta: Adds PR comments handling rule to guideline
Added a rule about responding to inline comments in PRs. Sometimes it takes additional effort to ensire that something was addressed. If this rule is present and respected then it would be easier t...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
Agreed, at one point I after having read the paragraph I thought we're encouraging the user to reset the variable.
eskultety created a comment on a pull request on containerbuildsystem/cachi2
> One more thing, that I probably mentioned somewhere, if we want to add platform qualifier in the PURLs: https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst#gem Good point.
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
`packages` is a mutable argument to a function. Here you mutate it and effectively create a second (hidden) return value. It is not clear if this is intentional or not. If it is then please redesig...
a-ovchinnikov created a review on a pull request on containerbuildsystem/cachi2
Please squash commits that introduce and then update the same block. The change is at about 3k lines at this moment, it takes some time to navigate and review it.
a-ovchinnikov created a review on a pull request on containerbuildsystem/cachi2
Please squash commits that introduce and then update the same block. The change is at about 3k lines at this moment, it takes some time to navigate and review it.
slimreaper35 created a comment on a pull request on containerbuildsystem/cachi2
One more thing, that I probably mentioned somewhere, if we want to add platform qualifier in the PURLs: https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst#gem
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
I think we should replace evrything after the first sentence with: "cachi2 sets version to 'system' that is whichever version is installed on a system that will be building the package." A verbatim...
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
Indeed, thank you!
github-merge-queue[bot] deleted a branch containerbuildsystem/cachi2
gh-readonly-queue/main/pr-683-c94a1a24c1777036bbed121281c41be1b8f156f1
slimreaper35 closed a pull request on containerbuildsystem/cachi2
yarn: frozen-lockfile integration test
# Maintainers will complete the following section - [ ] Commit messages are descriptive enough - [ ] Code coverage from testing does not decrease and new code is covered - [ ] Docs updated (if...
github-merge-queue[bot] created a branch on containerbuildsystem/cachi2
gh-readonly-queue/main/pr-683-c94a1a24c1777036bbed121281c41be1b8f156f1 - Cachi2 is a CLI tool that pre-fetches your project's dependencies to aid in making your build process network-isolated.
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
What? Are you saying no sneaky overrides to a value that will always pass the test are allowed?!
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
You need to actually make use of the parametrize values :).