Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
Validation will be happening elsewhere (namely when we attempt to read package.json to create an instance). A validator here would introduce coupling with filesystem.
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
Good point. Done.
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
Oh, I see it now! While I am not 100% agree with the "more readable" part I'll give it a try.
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
I am sorry, but mode="after" is useless: package.json is used to instantiate a Workspace, moreover, there is a validator that makes sure that package.json contains a name. By the time we get to "af...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
This line actually causes this commit not to pass mypy in a rebase because the attribute is added by the next one.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
This warning debate has IMO gone out of hand a bit, let's just agree on keeping it, it's just a string of characters after all that doesn't decrease the quality of the output and can potentially on...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
**Commit message**: nitpick: All true except that bundler apparently attempts to do this only with Z-streams, a version mismatch in Y-stream or major leads to a warning only that bundler isn't try...
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
I would rather give users another clue. There are many ways a build could go wrong, messing with binary dependencies is just one of those. I would expect a user to start debugging a failing build w...
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
Missed the 'system' part yesterday, it does work after all.
slimreaper35 created a review comment on a pull request on containerbuildsystem/cachi2
IMO, this is an unnecessary warning. Users should know, that they set `allow_binary`.
slimreaper35 created a review comment on a pull request on containerbuildsystem/cachi2
```suggestion log.warning("Skipping platform-specific gem %s because 'allow_binary' option is disabled", full_name) ```
slimreaper35 created a review on a pull request on containerbuildsystem/cachi2
I miss generated SBOM from e2e tests.
slimreaper35 created a review on a pull request on containerbuildsystem/cachi2
I miss generated SBOM from e2e tests.
a-ovchinnikov created a comment on a pull request on containerbuildsystem/cachi2
Could you please update the PR following https://github.com/containerbuildsystem/cachi2/pull/673/files#r1805975604 suggestion? The usage section would need a note containing this comment: https://g...
a-ovchinnikov created a comment on a pull request on containerbuildsystem/cachi2
https://github.com/containerbuildsystem/cachi2/issues/662 makes this moot . Let's switch to nox (or tox).
dependabot[bot] created a comment on a pull request on containerbuildsystem/cachi2
Superseded by #690.
