Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dependabot[bot] closed a pull request on containerbuildsystem/cachi2
build(deps): bump the pydantic group with 2 updates
Bumps the pydantic group with 2 updates: [pydantic](https://github.com/pydantic/pydantic) and [pydantic-core](https://github.com/pydantic/pydantic-core). Updates `pydantic` from 2.9.1 to 2.9.2 <de...
dependabot[bot] opened a pull request on containerbuildsystem/cachi2
build(deps): bump the pydantic group across 1 directory with 2 updates
Bumps the pydantic group with 2 updates in the / directory: [pydantic](https://github.com/pydantic/pydantic) and [pydantic-core](https://github.com/pydantic/pydantic-core). Updates `pydantic` from...
dependabot[bot] created a branch on containerbuildsystem/cachi2
dependabot/pip/pydantic-913fb37b4d - Cachi2 is a CLI tool that pre-fetches your project's dependencies to aid in making your build process network-isolated.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
> A model represents some structured data, its responsibility is to make sure that all necessary fields were supplied. Actually, since you're missing a validator for the `path` attribute, you mi...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
There's missing a validator for the path if it even exists as part of the project.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
A private helper maybe?
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
**Commit message:** To make it more useful please mention what constitutes a workspace which lead us to this representation.
slimreaper35 closed a pull request on containerbuildsystem/cachi2
cachi2 output image
# Maintainers will complete the following section - [ ] Commit messages are descriptive enough - [ ] Code coverage from testing does not decrease and new code is covered - [ ] Docs updated (if...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
**Commit subject:** s/yar/yarn
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
Still feels weird to have in the code like that at any point in time, but okay, not a blocker.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
> Sorry, I don't follow why map would be more idiomatic? I need to join several flat iterables into anther flat iterable, chain.from_iterable does exactly that. To the best of my knowledge map cann...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
> I don't think a model should be validating filesystem, so will keep this one unchanged for now. Generally true, see my other comment on this though; resolving based on https://github.com/conta...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
> Checking that some file is present somewhere is not models responsibility. Someone else must do this I'd argue that the model is to represent a workspace which *is defined** by the presence of...
eskultety created a comment on a pull request on containerbuildsystem/cachi2
The idea here is (https://github.com/containerbuildsystem/cachi2/milestone/3) to stay independent which also means the main container registry we use for releases, which most likely ends up being G...
eskultety created a review on a pull request on containerbuildsystem/cachi2
Tiny update to the commit message needed, otherwise ACK.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
> Checking messages is a questionable idea because it tightly couples code and tests. A typo or a new, clearer message would mean that tests must change too and this is bad because no change is log...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
The logic was eventually dropped -> resolving.
eskultety created a comment on a pull request on containerbuildsystem/cachi2
> We can at least add a warning when extracting metadata from setup.py People should be aware by now, do we want to hold everyone's hand? I mean displaying a warning for users who genuinely need...