Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
eskultety created a review on a pull request on containerbuildsystem/cachi2
What I think we're really doing a bad job here is the non-transparency of the Makefile that removal of variables just isn't going to improve much/at all. I think we're long overdue on something lik...
eskultety created a review on a pull request on containerbuildsystem/cachi2
What I think we're really doing a bad job here is the non-transparency of the Makefile that removal of variables just isn't going to improve much/at all. I think we're long overdue on something lik...
eskultety created a review on a pull request on containerbuildsystem/cachi2
What I think we're really doing a bad job here is the non-transparency of the Makefile that removal of variables just isn't going to improve much/at all. I think we're long overdue on something lik...
slimreaper35 created a review comment on a pull request on containerbuildsystem/cachi2
Personally, I use `tox -e py3 -- -k pip`.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
This commit is irrelevant to the Makefile changes topic, please propose this in a separate PR for cleaner bookkeeping.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
> Can we do this? We can detect a version that is used in a fetch environment, but there is no guarantee that this same version is used in build environment. Yes we can! The reason I suggested ...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
Yes, which means that this hunk needs to go.
brunoapimentel created a review comment on a pull request on containerbuildsystem/cachi2
I have a small suggestion to avoid needing this nested loop: ``` existing_paths = set() for artifact in artifacts: destination = output_dir.join_within_root(artifact.resolved_target) ...
brunoapimentel created a review comment on a pull request on containerbuildsystem/cachi2
I feel like the `GenericArtifact` class is not bringing too much value, it seems mostly redundant. Maybe we can add the `resolved_path` attribute in the `LockfileArtifact` class itself, or even rel...
brunoapimentel created a review comment on a pull request on containerbuildsystem/cachi2
On the other hand, I think I've been mostly calling tox directly, so if nobody else finds it uself, let's drop it.
brunoapimentel created a review comment on a pull request on containerbuildsystem/cachi2
I don't mind this change, but I find useful to have the TOX_ARGS variable here, as it allows us to filter which tests to execute: ``` TOX_ARGS="-k pip" make test-unit ``` I always missed it i...
slimreaper35 opened a pull request on containerbuildsystem/cachi2
Makefile improvements
# Maintainers will complete the following section - [ ] Commit messages are descriptive enough - [ ] Code coverage from testing does not decrease and new code is covered - [ ] Docs updated (if...
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
I don't think a model should be validating filesystem, so will keep this one unchanged for now.
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
Fair enough, this does attract too much attention.
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
To be honest I trusted cachito implementation on this one. I'll expand the comment here and will try splitting everything out into a separate commit.
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
Dropping everything that is related to nested workspaces.
brunoapimentel opened an issue on containerbuildsystem/cachi2
Report the use of experimental features in the SBOM
In Cachi2, experimental features are opt-in and are not ready for use in production. To further help users understand this, and to provide means for other tools that consume the produced SBOM to ta...
taylormadore closed an issue on containerbuildsystem/cachi2
Yarn 1.x: Detect when yarn.lock has been changed
The `yarn install` command has the [`--frozen-lockfile`](https://classic.yarnpkg.com/lang/en/docs/cli/install/#toc-yarn-install-frozen-lockfile) flag that is supposed to fail if an update is needed...
taylormadore created a comment on an issue on containerbuildsystem/cachi2
Closing it is fine with me
brunoapimentel created a comment on an issue on containerbuildsystem/cachi2
I filed #687 to follow up on the experimental feature toggle, so I'm closing this issue as #649 addressed it.
brunoapimentel closed an issue on containerbuildsystem/cachi2
Define a clear process for experimental features
The current process to start the development of a new package manager starts with the proposal and acceptance of a thorough design document. The actual implementation can only begin after the desig...