Currently, Cachi2 allows the user to specify the `dev-package-managers` flag to enable the usage of experimental package managers. This, however, brings the problem that all experimental package ma...
Also, it might be worth discussing [setup.py](https://setuptools.pypa.io/en/latest/userguide/quickstart.html#setuppy-discouraged) as:
> New projects are advised to avoid setup.py configurations ...
I'm getting an error when trying to run Cachi2 on a sample repo I have locally, I believe this line is the culprit:
```
raise PydanticSchemaGenerationError(
pydantic.errors.PydanticSchemaGenerat...
Note that our logging is far from ideal, so we may want to improve on that in the future. That is irrelevant to this thread and PR and so I won't digress.
> This feels like a message that could be constructed at multiple places:
> ```
> assert some_message_contains_substring("Found a binary dependency", caplog.messages)
> assert some_message_conta...
> I gave it a quick test and it doesn't appear to.
> This might be something we want to do later, since it doesn't seem particularly complicated to resolve.
Understood.
Do we want to keep is...
> You still stuffed everything into commit 1. The changes can be introduced gradually by adding one unit test at a time and turning off that particular test area in the more complex unit test you'r...
If I replace the function with `assert "..." in caplog.text` everything passes. But it is not ideal either.
> Now imagine an error message which has been constructed at multiple places (unwindin...
> Will this cause hermetic builds to fail?
I gave it a quick test and it doesn't appear to
My feelings on this are that it isn't on the critical path, so this issue definitely doesn't need to...
You still stuffed everything into commit 1. The changes can be introduced gradually by adding one unit test at a time and turning off that particular test area in the more complex unit test you're ...
You still stuffed everything into commit 1. The changes can be introduced gradually by adding one unit test at a time and turning off that particular test area in the more complex unit test you're ...
> > After having carefully gone through the unit tests which I didn't do in my first round of reviews I think we're actually opening us up for potential issues with pyproject.toml setup.py etc. mix...
Interesting behaviour....which means that it's not just the problem of our e2e test, users will suffer from this as well in hermetic envs and we surely don't want Bundler to fail the installation d...
Mostly minor comments on top of @slimreaper35's . The default bundler version downgrade behaviour raised a red flag for me and so I believe we need to set `BUNDLE_VERSION`.
Mostly minor comments on top of @slimreaper35's . The default bundler version downgrade behaviour raised a red flag for me and so I believe we need to set `BUNDLE_VERSION`.
I think that was intended. From what I observed, `output_dir` is the cachi2 output folder. But the generic dependencies should go under `{output_dir}/DEFAULT_DEPS_DIR` and nowhere else, so it made ...
This does not make sense to me. There is an attribute in the class that is Optional and is not set when creating the object. It is only overwritten here. In addition, you try to do a comparison via...