Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
brunoapimentel opened an issue on containerbuildsystem/cachi2
Allow experimental features to be toggled individually
Currently, Cachi2 allows the user to specify the `dev-package-managers` flag to enable the usage of experimental package managers. This, however, brings the problem that all experimental package ma...
slimreaper35 created a comment on a pull request on containerbuildsystem/cachi2
Also, it might be worth discussing [setup.py](https://setuptools.pypa.io/en/latest/userguide/quickstart.html#setuppy-discouraged) as: > New projects are advised to avoid setup.py configurations ...
brunoapimentel created a review comment on a pull request on containerbuildsystem/cachi2
I'm getting an error when trying to run Cachi2 on a sample repo I have locally, I believe this line is the culprit: ``` raise PydanticSchemaGenerationError( pydantic.errors.PydanticSchemaGenerat...
slimreaper35 created a review comment on a pull request on containerbuildsystem/cachi2
Oh I found this: https://github.com/containerbuildsystem/cachi2/pull/128
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
Note that our logging is far from ideal, so we may want to improve on that in the future. That is irrelevant to this thread and PR and so I won't digress.
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
> This feels like a message that could be constructed at multiple places: > ``` > assert some_message_contains_substring("Found a binary dependency", caplog.messages) > assert some_message_conta...
eskultety created a comment on an issue on containerbuildsystem/cachi2
> I gave it a quick test and it doesn't appear to. > This might be something we want to do later, since it doesn't seem particularly complicated to resolve. Understood. Do we want to keep is...
slimreaper35 created a comment on a pull request on containerbuildsystem/cachi2
> You still stuffed everything into commit 1. The changes can be introduced gradually by adding one unit test at a time and turning off that particular test area in the more complex unit test you'r...
slimreaper35 created a review comment on a pull request on containerbuildsystem/cachi2
If I replace the function with `assert "..." in caplog.text` everything passes. But it is not ideal either. > Now imagine an error message which has been constructed at multiple places (unwindin...
taylormadore created a comment on an issue on containerbuildsystem/cachi2
> Will this cause hermetic builds to fail? I gave it a quick test and it doesn't appear to My feelings on this are that it isn't on the critical path, so this issue definitely doesn't need to...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
You don't explain anywhere why you're dropping this check.
eskultety created a review on a pull request on containerbuildsystem/cachi2
You still stuffed everything into commit 1. The changes can be introduced gradually by adding one unit test at a time and turning off that particular test area in the more complex unit test you're ...
eskultety created a review on a pull request on containerbuildsystem/cachi2
You still stuffed everything into commit 1. The changes can be introduced gradually by adding one unit test at a time and turning off that particular test area in the more complex unit test you're ...
eskultety created a comment on a pull request on containerbuildsystem/cachi2
> > After having carefully gone through the unit tests which I didn't do in my first round of reviews I think we're actually opening us up for potential issues with pyproject.toml setup.py etc. mix...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
Interesting behaviour....which means that it's not just the problem of our e2e test, users will suffer from this as well in hermetic envs and we surely don't want Bundler to fail the installation d...
eskultety created a review on a pull request on containerbuildsystem/cachi2
Mostly minor comments on top of @slimreaper35's . The default bundler version downgrade behaviour raised a red flag for me and so I believe we need to set `BUNDLE_VERSION`.
eskultety created a review on a pull request on containerbuildsystem/cachi2
Mostly minor comments on top of @slimreaper35's . The default bundler version downgrade behaviour raised a red flag for me and so I believe we need to set `BUNDLE_VERSION`.
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
I think that was intended. From what I observed, `output_dir` is the cachi2 output folder. But the generic dependencies should go under `{output_dir}/DEFAULT_DEPS_DIR` and nowhere else, so it made ...
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
Oh, cool. Will fix!
slimreaper35 created a review comment on a pull request on containerbuildsystem/cachi2
nitpick: I think it is worth adding a short description for all attributes in the class.
slimreaper35 created a review comment on a pull request on containerbuildsystem/cachi2
This does not make sense to me. There is an attribute in the class that is Optional and is not set when creating the object. It is only overwritten here. In addition, you try to do a comparison via...