Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ben-alkov created a comment on a pull request on containerbuildsystem/cachi2
We've got 80% coverage of new code. I figure somewhere between 2-5 more unit tests should cover everything, and they'll all be pretty straightforward.
ben-alkov created a review comment on a pull request on containerbuildsystem/cachi2
Gah. Copy-pasta.
taylormadore created a review comment on a pull request on containerbuildsystem/cachi2
I think "zero-installs" are a term/feature that only really exists in Yarn v2+, so we might want to avoid using it here for Yarn 1.x. Same with the solution text mention of .yarn/cache
taylormadore created a review comment on a pull request on containerbuildsystem/cachi2
This conditional is a bit dense. Can it be broken down to make it more readable? Maybe some clearly-named, individual boolean variables for each of the conditions and then combine them for the return
taylormadore created a review comment on a pull request on containerbuildsystem/cachi2
At least for the initial implementation, I don't think we'll need to get/set the packageManager field in package.json
eskultety opened a draft pull request on containerbuildsystem/cachi2
[gomod] Use a temporary working copy of the input repository
Depends on: #714 Relates to: https://github.com/containerbuildsystem/cachi2/issues/707 # Maintainers will complete the following section - [ ] Commit messages are descriptive enough - [ ] ...
eskultety opened an issue on containerbuildsystem/cachi2
Deprecate the --force-gomod-tidy CLI flag
Running `go mod tidy` on the input source repository will result in dirtying the repo which is likely an undesirable effect that we should avoid doing. On the other hand, if we keep the flag and st...
eskultety opened an issue on containerbuildsystem/cachi2
Cachi2 prefetching is making changes on a source
We only use a working copy of the input source repository for the Yarn backends. All other package manager backends work on top of the input source directly which may result in some operations we p...
a-ovchinnikov created a review comment on a pull request on containerbuildsystem/cachi2
**Commit message** s/optioanl/optional
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
I agree, it dows improve readability. Fixed.
slimreaper35 created a review comment on a pull request on containerbuildsystem/cachi2
Maybe one more suggestion, `a` and `h` do not tell much about what it stands for. Btw. in the `LockfileArtifact` you have used: `ChecksumInfo(algo, digest) for algo, digest in self.checksums.items...
eskultety created a review comment on a pull request on containerbuildsystem/cachi2
> Urgent can coincide with regular release. True. I will update with your suggestion, but will swap the last 2 sentences as it makes more sense that way with the suggestion.
eskultety created a comment on an issue on containerbuildsystem/cachi2
@pierDipi FYI https://github.com/containerbuildsystem/cachi2/discussions/711 :)
kosciCZ created a review comment on a pull request on containerbuildsystem/cachi2
Good catch, that's a leftover from something I was testing. Removed.