Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
colemanw closed a pull request on civicrm/civicrm-core
Api3 Setting.revert - dont swallow errors, fix one reverting constant settings
Overview ---------------------------------------- `SettingsTest::testRevertAll` should be failing, because the underlying Setting.revert call isn't working. However it isn't because the api3 impl...
colemanw created a comment on a pull request on civicrm/civicrm-core
Looks good. One code style nitpick, there's a couple spots where I would have used `empty()` instead of `?? FALSE` but they're functionally equivalent (I just think empty is easier to read when you...
ufundo created a comment on a pull request on civicrm/civicrm-core
Looks like the fail was downloading iatspayments info from the extension feed. The url in the logs seems valid and works for me, if slowly - so my guess is its just a network timeout issue during...
ufundo created a comment on a pull request on civicrm/civicrm-core
This is now passing = hurrah. But I've removed
colemanw created a comment on a pull request on civicrm/civicrm-core
@mattwire thanks for this. I can probably think of a cleaner solution for that. Meanwhile can you just add a line or two to the sqlFunctionTest to cover this function?
mattwire opened a draft pull request on civicrm/civicrm-core
Make 'on_delete' accessible in DAO fields
Overview ---------------------------------------- I've written a bit of code to generate "ALTER TABLE" statements for missing foreign keys which hopefully I'll try and PR at some point. However, ...
demeritcowboy created a review comment on a pull request on civicrm/civicrm-core
I just noticed we need to exclude ones that have never even started, otherwise they end up in both lists. That would be ok if array_merge below merged them, but since the keys are numeric it actual...
demeritcowboy created a review comment on a pull request on civicrm/civicrm-core
`:label` should be `:name` ?
demeritcowboy created a review comment on a pull request on civicrm/civicrm-core
```suggestion ->addClause('OR', ['last_run', 'IS NULL'], ['last_run', '<=', 'last_run_end', TRUE]) ``` Otherwise it ends up including the unsuccessful ones that have run at least once succ...
demeritcowboy created a review comment on a pull request on civicrm/civicrm-core
```suggestion ->addClause('OR', ['last_run_end', 'IS NULL'], ['last_run', '>', 'last_run_end', TRUE]) ``` The code comment above has it right.
francescbassas created a comment on a pull request on civicrm/civicrm-core
@mattwire I tested in a SearchKit and it's working great 
mattwire created a comment on a pull request on civicrm/civicrm-core
@kcristiano makes sense - I've opened https://lab.civicrm.org/dev/core/-/issues/5545 to discuss
seamuslee001 pushed 2 commits to master civicrm/civicrm-core
seamuslee001 closed a pull request on civicrm/civicrm-core
SearchDisplay rewrites: don't truncate long field keys
Overview ---------------------------------------- SearchKit creates a unique key for each selected column. Sometimes these are short (`start_date`), but they can also get quite long (`GROUP_CONCA...
seamuslee001 created a comment on a pull request on civicrm/civicrm-core
@johntwyman can you fix the following style issues https://test.civicrm.org/job/CiviCRM-Style/2918/Civilint/ and the rebase and squish your commits into one?
seamuslee001 created a comment on a pull request on civicrm/civicrm-core
ping @colemanw @eileenmcnaughton
mattwire created a comment on a pull request on civicrm/civicrm-core
Funnily enough I had a need for this patch again yesterday as the mailings job was failing on a site and that caused 3 or 4 other jobs not to run because the mailings job kept trying to run before ...
mattwire created a comment on a pull request on civicrm/civicrm-core
Thanks @demeritcowboy now updated to properly handle jobs that never completed and jobs that completed before but are now failing (ie. last_run_end < last_run)
civibot[bot] created a comment on a pull request on civicrm/civicrm-core
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 <details> <summary><strong>Introduction for new contributors...</strong></summary> - If this is your first P...
johntwyman opened a pull request on civicrm/civicrm-core
Add APIv4 Contact.getMergedTo/getMergedFrom actions
Overview ---------------------------------------- This PR adds the APIv4 Contact actions getMergedFrom and getMergedTo. These are the APIv4 equivalent of the existing v3 actions. Before -----...
demeritcowboy created a comment on a pull request on civicrm/civicrm-core
I responded in chat. It looks like you can just add a TRUE: `['last_run_end', '<', 'last_run']` with `['last_run_end', '<', 'last_run', TRUE]`
civibot[bot] created a comment on a pull request on civicrm/civicrm-core
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 <details> <summary><strong>Introduction for new contributors...</strong></summary> - If this is your first P...
ufundo opened a draft pull request on civicrm/civicrm-core
SettingsManager::bootSettings - derive $civicrm_root global if not set
Overview ---------------------------------------- Derive a value for $civicrm_root, so we don't have to set it explicitly. Before ---------------------------------------- - $civicrm_root glo...