Overview
----------------------------------------
`SettingsTest::testRevertAll` should be failing, because the underlying Setting.revert call isn't working. However it isn't because the api3 impl...
Looks good. One code style nitpick, there's a couple spots where I would have used `empty()` instead of `?? FALSE` but they're functionally equivalent (I just think empty is easier to read when you...
Looks like the fail was downloading iatspayments info from the extension feed.
The url in the logs seems valid and works for me, if slowly - so my guess is its just a network timeout issue during...
@mattwire thanks for this. I can probably think of a cleaner solution for that. Meanwhile can you just add a line or two to the sqlFunctionTest to cover this function?
Overview
----------------------------------------
I've written a bit of code to generate "ALTER TABLE" statements for missing foreign keys which hopefully I'll try and PR at some point. However, ...
I just noticed we need to exclude ones that have never even started, otherwise they end up in both lists. That would be ok if array_merge below merged them, but since the keys are numeric it actual...
```suggestion
->addClause('OR', ['last_run', 'IS NULL'], ['last_run', '<=', 'last_run_end', TRUE])
```
Otherwise it ends up including the unsuccessful ones that have run at least once succ...
Overview
----------------------------------------
SearchKit creates a unique key for each selected column. Sometimes these are short (`start_date`), but they can also get quite long (`GROUP_CONCA...
@johntwyman can you fix the following style issues https://test.civicrm.org/job/CiviCRM-Style/2918/Civilint/ and the rebase and squish your commits into one?
Funnily enough I had a need for this patch again yesterday as the mailings job was failing on a site and that caused 3 or 4 other jobs not to run because the mailings job kept trying to run before ...
Thanks @demeritcowboy now updated to properly handle jobs that never completed and jobs that completed before but are now failing (ie. last_run_end < last_run)
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷
<details>
<summary><strong>Introduction for new contributors...</strong></summary>
- If this is your first P...
Overview
----------------------------------------
This PR adds the APIv4 Contact actions getMergedFrom and getMergedTo. These are the APIv4 equivalent of the existing v3 actions.
Before
-----...
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷
<details>
<summary><strong>Introduction for new contributors...</strong></summary>
- If this is your first P...
Overview
----------------------------------------
Derive a value for $civicrm_root, so we don't have to set it explicitly.
Before
----------------------------------------
- $civicrm_root glo...