Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mlutfy opened a pull request on civicrm/civicrm-core
dev/translation#90 Fix recurring unit translation on ContributionPage confirm
Overview ---------------------------------------- Fix from #31299 applied to the Contribution "Confirm" page. The changes are perhaps bigger than necessary, but I did a vimdiff between the C...
mlutfy pushed 3 commits to 5.79 civicrm/civicrm-core
mlutfy closed a pull request on civicrm/civicrm-core
dev/translation#90 address translation issue on membership
Overview ---------------------------------------- _A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions._ Before -----------------------...
mlutfy created a comment on a pull request on civicrm/civicrm-core
I tested a few scenarios and seems all OK. It was on Standalone, with PHP notices enabled, latest Smarty, etc. Before: 
mlutfy created a comment on a pull request on civicrm/civicrm-core
Should we remove the placeholder, if it cannot be translated?
mlutfy created a comment on a pull request on civicrm/civicrm-core
@jmcclelland I wasn't able to reproduce the bug on 'master'. I followed the steps you described to create a custom field for a specific event. Could you have a look at my sandbox: https://ml1.de...
mlutfy created a review comment on a pull request on civicrm/civicrm-core
@jmcclelland I'm not too familiar with this code - could you add a comment to explain the `where`? I feel like if this behaviour changes at some point in the future and custom fields are missing du...
mlutfy pushed 2 commits to master civicrm/civicrm-core
mlutfy closed a pull request on civicrm/civicrm-core
change param name for CRM_Core_Permission_Standalone::check...
...to something that means something.
mlutfy closed a pull request on civicrm/civicrm-core
[REF] AfformGui - Update editOptions code to ES6
Overview ---------------------------------------- Part of ongoing code updates to use ES6 instead of loDash Comments -------- Yes, I'm using AI to do these refactors. It works pretty well.
mlutfy pushed 2 commits to master civicrm/civicrm-core
mlutfy closed a pull request on civicrm/civicrm-core
Avoid duplicate ID on location form
Overview ---------------------------------------- Fix duplicate ID in HTML source of the location form when managing events. Before ---------------------------------------- The wrapping `<tr...
phma4 created a comment on a pull request on civicrm/civicrm-core
@mlutfy This would make sense. Apart from de_CH using _ss_ instead of _ß_, the differences between the two are minimal. There are some variances in grammar and spelling, but unlikely something that...
vingle created a comment on a pull request on civicrm/civicrm-core
@mlutfy looks good - RiverLea also doesn't put a width on the icon, and just adds a margin-right. I guess it might come from when it was using a background image sprite so the width needed setting.
eileenmcnaughton created a comment on a pull request on civicrm/civicrm-core
@MegaphoneJon - @seamuslee001 did the rc take of this & also 5.78 stable
eileenmcnaughton pushed 9 commits to master civicrm/civicrm-core
- Update deleted files list for #31296 d530781
- dev/core#5499 Fix missing translation on Relationships tab by setting module in the ts to afform in fieldSet d60a19c
- Merge pull request #31300 from seamuslee001/5.79 Update deleted files list for #31296 22bd216
- dev/core#5163 Afform - Fix conditionals for FK fields This regressed (again) with b5a3b63df as FK fields shouldn't a... e07ec92
- Merge pull request #31302 from seamuslee001/dev_core_5499 dev/core#5499 Fix missing translation on Relationships tab... 2aa2e0b
- Merge pull request #31304 from colemanw/afformFixDataTypeAgain dev/core#5163 Afform - Fix conditionals for FK fields 5aecf27
- fix administrators not seeing contributions with disabled financial type ac0e0e4
- Merge pull request #31308 from seamuslee001/5.79 fix administrators not seeing contributions with disabled financial... b4b6056
- Merge pull request #31303 from civicrm/5.79 5.79 0b4c4a5
seamuslee001 created a comment on a pull request on civicrm/civicrm-core
@totten I don't know when it started failing or not but this was in response to joe's comments here https://chat.civicrm.org/civicrm/pl/tbnh7q7xx7gtxkw3a4u9trdqzh about wpmaster
totten created a comment on a pull request on civicrm/civicrm-core
So just checking -- it's a new problem that only affects master? And thus a fix against master helps? Added `run-wordpress` label so we can see if it does any better. I have no general compl...
eileenmcnaughton pushed 2 commits to 5.78 civicrm/civicrm-core
eileenmcnaughton closed a pull request on civicrm/civicrm-core
fix administrators not seeing contributions with disabled financial type
Overview ---------------------------------------- Backport of #31308 to stable @eileenmcnaughton
colemanw pushed 3 commits to master civicrm/civicrm-core
- SearchKit - More efficient getFields call Fetch multiple fields at once instead of calling getFields repeatedly ed60f4a
- dev/core#5524 SearchKit - More sensible defaults for 1-1 joins 1-1 joins do not need any default conditions as they ... 191a584
- Merge pull request #31285 from colemanw/searchKitJoinDefaults dev/core#5524 SearchKit - More sensible defaults for 1... 1ffa17e
colemanw closed a pull request on civicrm/civicrm-core
dev/core#5524 SearchKit - More sensible defaults for 1-1 joins
Overview ---------------------------------------- Improves SearchKit user experience of adding 1-1 joins. Fixes https://lab.civicrm.org/dev/core/-/issues/5524 Before ------------------------...
civibot[bot] created a comment on a pull request on civicrm/civicrm-core
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 <details> <summary><strong>Introduction for new contributors...</strong></summary> - If this is your first P...
