Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
GabbasovDinar created a review comment on a pull request on cetmix/cetmix-tower
In this case there is no need to remember about any YAML file, and it is immediately clear from the code that a specific type of field is expected. the code is also cleaner and clearer
GabbasovDinar created a review comment on a pull request on cetmix/cetmix-tower
@ivs-cetmix Why not add field type validation as I pointed out above?
GabbasovDinar created a review comment on a pull request on cetmix/cetmix-tower
@ivs-cetmix in this case I suggest to return False explicitly so that there is no confusion in reading the code
ivs-cetmix pushed 1 commit to 14.0-t3987-cetmix_tower_yaml-file_templates_in_commands cetmix/cetmix-tower
- [IMP] cetmix_tower_yaml: exploded m2o fields Support "exploded" mode for m2o fields. In this mode related field is a... b5a5d03
ivs-cetmix created a review comment on a pull request on cetmix/cetmix-tower
@GabbasovDinar it's also checked [here](https://github.com/cetmix/cetmix-tower/blob/996f9a6f4e541a30b6831d5418783328398f7517/cetmix_tower_yaml/models/cx_tower_yaml_mixin.py#L151)
ivs-cetmix created a review comment on a pull request on cetmix/cetmix-tower
Then None value will be assigned to the key. Which is fine
angelinaanaki pushed 1 commit to 14.0-t3555-cetmix_tower_server-update_related_entities cetmix/cetmix-tower
- [IMP] Requested changes from review c551f42
ivs-cetmix created a review comment on a pull request on cetmix/cetmix-tower
@GabbasovDinar I agree. However we can imply naming conventions at the project level. It's also needed because of the YAML-> Odoo conversion. There simply no field types there so the only thing we...
GabbasovDinar created a review comment on a pull request on cetmix/cetmix-tower
what if processed_value returned None, because the model is not support yaml? from this eval `if comodel_name and self._model_supports_yaml(comodel_name):`
GabbasovDinar created a review comment on a pull request on cetmix/cetmix-tower
```suggestion if not value: return False comodel_name = field.comodel_name # Process value if comodel_name and self._model_suppo...
GabbasovDinar created a review comment on a pull request on cetmix/cetmix-tower
in this case there is no guarantee that the specified field will be exactly the relation field, it is necessary to check exactly its type without focusing on how the field is called: ```python ...
GabbasovDinar created a review on a pull request on cetmix/cetmix-tower
please, check my last comment
GabbasovDinar created a review comment on a pull request on cetmix/cetmix-tower
@angelinaanaki ok, maybe in this case we can modify the method: ```python def _prepare_variable_commands(self, field_names, force_record=None): """ TODO: Add docstring wh...
dessanhemrayev opened a pull request on cetmix/cetmix-tower
[14.0][FIX] cetmix_tower_server: Clean up Python command execution result
Renamed method _parse_ssh_command_results to _parse_command_results for using not only for SSH but for any command including Python one. Task: 3952
ivs-cetmix opened a draft pull request on cetmix/cetmix-tower
[14.0][IMP] cetmix_tower_yaml Many2one fields support
Add support for many2one fields export/import ----------------------------------------------- Field value is saved in yaml as a related record reference. Eg 'file_template_id: file_template_1'...
ivs-cetmix pushed 1 commit to 14.0-t3987-cetmix_tower_yaml-file_templates_in_commands cetmix/cetmix-tower
- [IMP] cetmix_tower_yaml: m2o fields support Add support for many2one fields export/import. Field value is saved in ... 996f9a6
ivs-cetmix created a branch on cetmix/cetmix-tower
14.0-t3987-cetmix_tower_yaml-file_templates_in_commands - Cetmix Tower
CetmixGitDrone pushed 1 commit to 14.0-dev cetmix/cetmix-tower
- [UPD] Update cetmix_tower_yaml.pot 7aa70d2
CetmixGitDrone created a comment on a pull request on cetmix/cetmix-tower
Congratulations, your PR was merged at 15c9ab6708f00f967010ef78c92e48e6e2c78252. Thanks a lot for contributing to cetmix. ❤️
CetmixGitDrone deleted a branch cetmix/cetmix-tower
14.0-t3980-cetmix_tower_server_yaml-file_template