Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
renovate[bot] closed a pull request on canonical/sdcore-nms-k8s-operator
chore(deps): update canonical/sdcore-github-workflows action to v2.3.0
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [canonical/sdcore-github-workflows](https://redirect.github.com/canonical/sdcore-github-workflows) ...
renovate[bot] opened a pull request on canonical/sdcore-nms-k8s-operator
chore(deps): update canonical/sdcore-github-workflows action to v2.3.0
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [canonical/sdcore-github-workflows](https://redirect.github.com/canonical/sdcore-github-workflows) ...
github-actions[bot] published a release on canonical/sdcore-nms-k8s-operator
Revision 755
resources: - nms-image: ghcr.io/canonical/sdcore-nms:1.0.0 resource-revision: 89 Static resources: Released to '1.6/edge/' at 07:11 UTC on 1 Dec 2024 ## What's Changed * chore: Igno...
github-actions[bot] created a tag on canonical/sdcore-nms-k8s-operator
rev755 - A charmed operator for SD-Core NMS
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
ohh true, I forgot we'll have the pebble notices so it changes everything. We need to be extra careful to avoid deadlock here :O Anyways, I don't think we need to include all this complicated log...
Gmerold created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
True. I think that's just a leftover from the previous implementation which actually did everything you described ;)
Gmerold created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
I guess the logic itself is fine here. The only problem is when to execute this. My comment above covers that part. The high level flow is: 1. gNB pushes its name to the data bag 2. NMS charm ...
Gmerold created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
Actually I think we should be running this logic on the event related to network config change (in our case, it's gonna be the Pebble notification). There's no point in running this on `relation_ch...
Gmerold created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
```suggestion raise ValueError(f"Invalid gNB name: {cu_name}") ```
patriciareinoso created a comment on a pull request on canonical/sdcore-nms-k8s-operator
UT coverage can be increased. ie. empty plmns list, missing relations, invalid tac over the upper range limit , PLMNs range values....
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
`on relation changed` we get the information from the remote databag and `on relation joined` we publish the information. Even though it's not that important because in our charms we will use the...
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
```suggestion pattern=r"^[0-9][0-9][0-9]?$", ```
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
```suggestion self.on.fiveg_core_gnb_relation_changed, ```
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
otherwise we can have 3 or more numbers. To be updated in the interface repo as well
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
```suggestion ```
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
since this test does not patch anything we can get rid of this
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
since this test does not patch anything we can get rid of this
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
Comment can be improved
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
otherwise we can have 3 or more numbers. To be updated in the interface repo as well
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
I know that setting a specific exception here fails, but I think that you can check the text in the exception (`Invalid fiveG core gNB data`) to make sure that it failed in the library when calling...
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
```suggestion ```
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
the comment can be improved
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
Update comment. This is no longer true
patriciareinoso created a review comment on a pull request on canonical/sdcore-nms-k8s-operator
```suggestion multiple PLMNs. ```
github-actions[bot] created a tag on canonical/sdcore-nms-k8s-operator
rev754 - A charmed operator for SD-Core NMS
github-actions[bot] published a release on canonical/sdcore-nms-k8s-operator
Revision 754
resources: - nms-image: ghcr.io/canonical/sdcore-nms:1.0.0 resource-revision: 88 Static resources: Released to '1.6/edge/TELCO-1450-add-fiveg-core-gnb-interface' at 13:33 UTC on 28 N...