Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pjfanning created a review comment on a pull request on apache/pekko-http
it's not useless - add it back
NavidJalali created a review comment on a pull request on apache/pekko-http
I think IntelliJ is deleting the Seq import, thinking its useless
pjfanning created a review comment on a pull request on apache/pekko-http
please revert this change - it is probably here for Scala 2.12 support and there is no reason for this PR to be changing these methods anyway
mdedetrich created a review comment on a pull request on apache/pekko-http
Can you fix this import so it matches the same style of imports currently in the file
mdedetrich created a review on a pull request on apache/pekko-http
There is just one minor thing regarding imports but otherwise lgtm. I also triggered the CI run
mdedetrich created a review on a pull request on apache/pekko-http
There is just one minor thing regarding imports but otherwise lgtm. I also triggered the CI run
NavidJalali created a comment on a pull request on apache/pekko-http
@pjfanning can you take another look when you get the time?
NavidJalali created a comment on a pull request on apache/pekko-http
@pjfanning I am honestly not sure what this code is really doing so I am a bit hesitant to assert things about this. I will have a look at the related tests to see if I can confidently test it
pjfanning created a comment on a pull request on apache/pekko-http
* seems sensible to change this * is there an easy way to get to add a unit test?
NavidJalali opened a pull request on apache/pekko-http
Fix partial match
I hit this case in a test and it threw. I am not sure if when `trailer.headers` is empty, it should return None or a parsed frame with empty headers but I figured the guard was there for a reason
pjfanning created a comment on an issue on apache/pekko-http
> No, it's a user error here. > > You have to be very careful about what you do in `App` classes (even in Scala 2) and that has become more so in Scala 3 (known issue). > > That you reinstate...
pjfanning closed an issue on apache/pekko-http
issue observed with pekko-http-cors when Scala 3 used
The issue and POC is described in https://github.com/pjfanning/swagger-pekko-http-sample/issues/3
jrudolph created a comment on an issue on apache/pekko-http
No, it's a user error here. You have to be very careful about what you do in `App` classes (even in Scala 2) and that has become more so in Scala 3 (known issue). That you reinstate the whole...
pjfanning created a comment on an issue on apache/pekko-http
@lomigmegard It looks like @jrudolph has worked out that this issue is in the way that Scala 3 handles the `cors()(...)` call. https://github.com/pjfanning/swagger-pekko-http-sample/issues/3#issue...
lomigmegard created a comment on an issue on apache/pekko-http
@pjfanning no worries, happy to help :) I will have a look this weekend, very strange behavior...
pjfanning created a comment on an issue on apache/pekko-http
@lomigmegard Apologies to ping you on this since you probably thought that by donating the http-cors code to Pekko was the end of it. Feel free to ignore this but if you have bandwidth, you know th...
pjfanning opened an issue on apache/pekko-http
issue observed in pekko-http-cors when Scala 3 used
The issue and POC is described in https://github.com/pjfanning/swagger-pekko-http-sample/issues/3