Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
nathanlo99 created a comment on a pull request on apache/kvrocks
just to say it, it would be nice to have the typos script run as a precommit hook or lint: it's a bit unideal to get the workflow approved by a reviewer just to find out you've introduced a typo in...
sonarcloud[bot] created a comment on a pull request on apache/kvrocks
## [](https://sonarcloud.io/dashboard?id=...
PragmaTwice created a comment on a pull request on apache/kvrocks
Do we need to add "exclusive" flag to `flushdb` and `flushall`? cc @git-hulk
PragmaTwice created a review comment on a pull request on apache/kvrocks
Hmm it does need some work. Like such a workflow: ``` lock ExecuteCommand (block and return) unlock lock Callback (timeout or satisfied) unlock ```
PragmaTwice created a review comment on a pull request on apache/kvrocks
I'm not sure if we can just merge this first and then plan to refactor to a "quick" scan. WDYT? cc @mapleFU @git-hulk
sonarcloud[bot] created a comment on a pull request on apache/kvrocks
## [](https://sonarcloud.io/dashboard?id=...
PragmaTwice created a review comment on a pull request on apache/kvrocks
Yeah we need to ensure it works well on blocking commands.
PragmaTwice created a review comment on a pull request on apache/kvrocks
https://github.com/apache/kvrocks/issues/2563#issuecomment-2423583948 Seems fine.
mapleFU created a review comment on a pull request on apache/kvrocks
what raise my curiousity is that, would this be dangerous on blocking command? Should we set a "relock-callback" for them?
mapleFU created a review comment on a pull request on apache/kvrocks
I'm afraid this change the syntax a bit but this lgtm now. Maybe we can losen the check with `spec` cc @PragmaTwice
mapleFU created a review on a pull request on apache/kvrocks
`MultiLockGuard` used to be forced used in some commands, but now it's been likely not to be used, should we doc it in `class MultiLockGuard`?
mapleFU created a review comment on a pull request on apache/kvrocks
```suggestion [lock_keys, this](const std::vector<std::string> &args, const CommandKeyRange &key_range) { ``` ?
git-hulk published a release on apache/kvrocks
2.10.1
This release mainly addresses some critical bugs found in 2.10.0. ## Bug Fixes - fix(stream): change XREADGROUP response for empty read response #2569 by @git-hulk - fix(stream): Fix XPENDI...
git-hulk created a tag on apache/kvrocks
v2.10.1 - Apache Kvrocks is a distributed key value NoSQL database that uses RocksDB as storage engine and is compatible with Redis protocol.
PragmaTwice pushed 1 commit to unstable apache/kvrocks
- feat(cmd): make key range fields private in CommandAttributes (#2621) 5fccd57
PragmaTwice closed a pull request on apache/kvrocks
feat(cmd): make key range fields private in CommandAttributes
Here we make `key_range`, `key_range_gen` and `key_range_vec_gen` private to ensure that users will not use them in a wrong way.
sonarcloud[bot] created a comment on a pull request on apache/kvrocks
## [](https://sonarcloud.io/dashboard?id=...