Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
sonarcloud[bot] created a comment on a pull request on apache/kvrocks
## [](https://sonarcloud.io/dashboard?id=...
PragmaTwice pushed 1 commit to unstable apache/kvrocks
- feat(cmd): avoid to use CommandAttributes::flags directly (#2619) c525d7a
PragmaTwice closed a pull request on apache/kvrocks
feat(cmd): avoid to use CommandAttributes::flags directly
We should use `CommandAttributes::GenerateFlags` instead of accessing the `flags` member directly.
PragmaTwice created a review comment on a pull request on apache/kvrocks
Yeah, `0,0,0` is not clear enough.
sonarcloud[bot] created a comment on a pull request on apache/kvrocks
## [](https://sonarcloud.io/dashboard?id=...
PragmaTwice created a review comment on a pull request on apache/kvrocks
Some times we cannot get the cmd args, so maybe the initial flags is needed. Also I currently don't want to touch some legacy files.
mapleFU created a review comment on a pull request on apache/kvrocks
Minor question: why `InitialFlags()` in some cases?
PragmaTwice created a comment on a pull request on apache/kvrocks
Also I plan to make key_range and other related members private in the next PR.
PragmaTwice created a comment on a pull request on apache/kvrocks
> What about making it private to avoid some explicit calling? ( Current method lgtm but I think it's easy to use it directly next time) Done.
PokIsemaine created a comment on an issue on apache/kvrocks
We might be able to use a script flag like `no-atomic` (or maybe the flag name isn't appropriate, we can discuss it further) to allow the user to choose to execute the script completely exclusively...
PokIsemaine opened a pull request on apache/kvrocks
refactor: hoist key mutexes
isseus: https://github.com/apache/kvrocks/issues/2563
sonarcloud[bot] created a comment on a pull request on apache/kvrocks
## [](https://sonarcloud.io/dashboard?id=...
mapleFU created a comment on a pull request on apache/kvrocks
What about making it private to avoid some explicit calling?
PragmaTwice created a comment on a pull request on apache/kvrocks
> Is this to avoid not calling `flag_gen` fn if having? Exactly.
mapleFU created a comment on a pull request on apache/kvrocks
Is this to avoid not calling `flag_gen` fn if having?
PragmaTwice opened a pull request on apache/kvrocks
feat(cmd): avoid to use CommandAttributes::flags directly
We should use `CommandAttributes::GenerateFlags` instead of accessing the `flags` member directly.
mapleFU pushed 1 commit to unstable apache/kvrocks
- feat(config): Minor update comment for compression_start_level error code (#2615) a738122
mapleFU closed a pull request on apache/kvrocks
feat(config): Minor update comment for compression_start_level error code
sonarcloud[bot] created a comment on a pull request on apache/kvrocks
## [](https://sonarcloud.io/dashboard?id=...
