Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mapleFU opened an issue on apache/kvrocks
[CI][Flacky] TestList/BLMPOP_test_blocked_served_bothKey_FIFO_countOver_LEFT failed
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/kvrocks/issues) and found no similar issues. ### Version ``` --- FAIL: TestList (90.51s) --- FAIL: ...
mapleFU created a comment on a pull request on apache/kvrocks
Would you mind also add example for how you'd like use this? ( better on doc of cli or doc of project?)
mapleFU created a review comment on a pull request on apache/kvrocks
Actually I don't really understand how this works, seems this create a checkpoint when opening the file? Do you need create it on server and consume it on cli?
PragmaTwice created a review comment on a pull request on apache/kvrocks
Hmm I think we need to move them to Storage::Open, also the throw can be replaced then.
PragmaTwice created a review comment on a pull request on apache/kvrocks
```suggestion {"snapshot-dir", true, new StringField(&snapshot_dir, "")}, ``` I think it should be read-only.
PragmaTwice created a review comment on a pull request on apache/kvrocks
Hmmm I think we'd better refactor the logic, so that the SCAN can be quick, instead of a long-time blocking scan. E.g. we can scan a fixed maximum numbers of keys even if the limit/cnt is not reach.
nathanlo99 created a review comment on a pull request on apache/kvrocks
Thanks, this makes sense: this is done now
nathanlo-hrt created a review comment on a pull request on apache/kvrocks
it seems like `cnt` is only incremented when we actually add a key to the result, so the loop will continue until no more keys match the prefix, or `limit` keys are inserted into the result vector
mapleFU closed an issue on apache/kvrocks
Make configurable compression for L0-L1
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/kvrocks/issues) and found no similar issues. ### Motivation I have high write rate, and data have ...
mapleFU opened a pull request on apache/kvrocks
feat(config): Minor update comment for compression_start_level error code
mapleFU created a review comment on a pull request on apache/kvrocks
Oh here we should just change content to `return {Status::NotOK, "compression_start_level must < rocksdb levels count"};`
mapleFU created a review comment on a pull request on apache/kvrocks
Oh I catch a problem here, should we weeken to `!(compression_start_level > KVROCKS_MAX_LSM_LEVEL)`?
git-hulk created a tag on apache/kvrocks
v2.10.1-rc1 - Apache Kvrocks is a distributed key value NoSQL database that uses RocksDB as storage engine and is compatible with Redis protocol.
PragmaTwice pushed 1 commit to unstable apache/kvrocks
- feat(config): add `rocksdb.compression_start_level` to allow configure levels without compression (#2605) Co-authore... e0de934
PragmaTwice closed a pull request on apache/kvrocks
feat(config): add `rocksdb.compression_start_level` to allow configure levels without compression
references: https://github.com/apache/kvrocks/issues/2602 add `rocksdb.compression_start_level` to allow configure levels without compression
PragmaTwice created a review comment on a pull request on apache/kvrocks
Ahh it's right. Just a confused `level` between `compression_start_level` and `compression_level`..
PragmaTwice created a review comment on a pull request on apache/kvrocks
Also is compression level equals to LSM level?