Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
leenagupte created a review comment on a pull request on alphagov/frontend
It feels odd having this level of presentation data in what will ultimately become the content item. Should this always be `0` if `minimal` is true? Could `minimal` be used to determine the `mar...
leenagupte created a review comment on a pull request on alphagov/frontend
I like this. I think this logic will make it easier to move the image logic here as well if we wanted, so it too could be defined as a block.
leenagupte created a review on a pull request on alphagov/frontend
This looks great and works like a charm. I have one inline question about how / where `margin_bottom` is defined.
leenagupte created a review on a pull request on alphagov/frontend
This looks great and works like a charm. I have one inline question about how / where `margin_bottom` is defined.
andysellick opened a pull request on alphagov/frontend
Add small charts
⚠️ This repo is Continuously Deployed: make sure you [follow the guidance](https://docs.publishing.service.gov.uk/manual/development-pipeline.html#merge-your-own-pull-request) ⚠️ ## What - ad...
andysellick created a branch on alphagov/frontend
add-small-charts - Serves the homepage, transactions and some index pages on GOV.UK
leenagupte created a review comment on a pull request on alphagov/frontend
To be honest, I'm not sure if this model is really needed as the you can just use `block.data["title"]` etc in the views. However being able to call `block.title` is tidier.
leenagupte created a review comment on a pull request on alphagov/frontend
I love that you've added model tests ⭐
leenagupte created a review on a pull request on alphagov/frontend
This looks good from a backend perspective. 👍 As there's a lot of frontendy changes, I'll let Andy approve.
leenagupte created a review on a pull request on alphagov/frontend
This looks good from a backend perspective. 👍 As there's a lot of frontendy changes, I'll let Andy approve.
andysellick pushed 2 commits to main alphagov/frontend
andysellick closed a pull request on alphagov/frontend
Change statistics data
⚠️ This repo is Continuously Deployed: make sure you [follow the guidance](https://docs.publishing.service.gov.uk/manual/development-pipeline.html#merge-your-own-pull-request) ⚠️ ## What - us...
leenagupte created a review on a pull request on alphagov/frontend
LGTM 👍 Thanks for cleaning this up 🥇
andysellick created a review comment on a pull request on alphagov/frontend
I'd also put the `data-module` on the parent, if that's not going to cause a problem.
andysellick created a review comment on a pull request on alphagov/frontend
Seems like the BEM's got a bit confusing here... `app-b-main-nav--border` is a modifier class, but it's being used as the parent class. I think the first class that wraps the whole block should be ...
andysellick created a review comment on a pull request on alphagov/frontend
The focus state for desktop links seems to be offset up by about a pixel? Not sure if that's intentional?  ⚠️ ## What Clean ...
andysellick pushed 1 commit to tidy-task-page alphagov/frontend
- Add document list block - needed for the bottom of this page fcd2860
andysellick created a review comment on a pull request on alphagov/frontend
Good shout, have converted 👍