Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
richardTowers created a review comment on a pull request on alphagov/frontend
To a degree, this gets us into the heart of the problem with this whole "blocks" approach. If the user of the publishing system is allowed to pick from a list of arbitrary blocks, and stack and ...
matthillco created a review comment on a pull request on alphagov/frontend
OK, understood. I think I'll revisit this once I've nailed the approach: if we end up using a mixin we might not need this named class at all.
leenagupte pushed 1 commit to landing-pages-backend-data-statistics-scaffold alphagov/frontend
- Refactor the rows method in the statistics block Uses a `find` with an include to get the existing row. This is beca... 43acb4f
leenagupte pushed 1 commit to landing-pages-backend-data-statistics-scaffold alphagov/frontend
- Refactor the rows method in the statistics block Uses a `find` with an include to get the existing row. This is beca... 14ae86a
matthillco created a review comment on a pull request on alphagov/frontend
Yes I did weigh this up but felt that given possible uncertainly over final content, it might be useful for content editors to have some control of how much spacing to apply around govspeak element...
maxgds created a review comment on a pull request on alphagov/frontend
Using "app" is not a pattern we use anywhere but components, though, let's avoid that.
matthillco created a review comment on a pull request on alphagov/frontend
It seemed prudent to offer it as an option and as a corollary to having the bottom margin. I understand it's possibly an example of solving a problem we don't yet have, happy to remove it in that c...
matthillco created a review comment on a pull request on alphagov/frontend
I think keeping `app` in the name is prudent since it helps identify where the style is coming from: that's useful for other developers who might be looking at the markup to obtain clues for where ...
maxgds created a review comment on a pull request on alphagov/frontend
Worth a chat with Jeremy to get his thoughts on both getting an accurate figure and seeing if it can align with the DS scales, even if the answer is no.
matthillco created a review comment on a pull request on alphagov/frontend
I eyeballed it based on the Figma design, which doesn't seem to provide a way of measuring it exactly. I can find out the exact figure and change it as necessary. I did look at the responsive sc...
AshGDS created a review comment on a pull request on alphagov/frontend
@leenagupte Whoops, Monday morning brain - have removed now!
AshGDS pushed 1 commit to heading-tweaks alphagov/frontend
- Add basic heading block When govspeak only contains a YouTube video, it removes the paragraph tag, and therefore the... 28bb313
leenagupte created a review comment on a pull request on alphagov/frontend
If the setting is no longer in the YAML, and I assume that means that the padding should always be "true", then this line can be removed too.
unoduetre opened a pull request on alphagov/frontend
Upgrade express package
⚠️ This repo is Continuously Deployed: make sure you [follow the guidance](https://docs.publishing.service.gov.uk/manual/development-pipeline.html#merge-your-own-pull-request) ⚠️ ## What Upgr...
unoduetre pushed 1 commit to upgrade-express-package alphagov/frontend
- Upgrade express package 15a236d
unoduetre created a branch on alphagov/frontend
upgrade-express-package - Serves the homepage, transactions and some index pages on GOV.UK
maxgds created a review comment on a pull request on alphagov/frontend
Are you sure this figure is right? Didn't look like that much to me on the PDF. Also, have you looked at using the responsive rather than the static spacing from the design system - ideally we ...
