Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
andysellick created a review comment on a pull request on alphagov/frontend
I think we want to avoid having margins specified in the content item, because that implies that this is something that will be configured by the user, which I don't think we would want (could pote...
andysellick created a review on a pull request on alphagov/frontend
Took me several comments to get to my overall thoughts about this approach - probably best to just skip to the last comment first 👍
andysellick created a review on a pull request on alphagov/frontend
Took me several comments to get to my overall thoughts about this approach - probably best to just skip to the last comment first 👍
AshGDS created a review comment on a pull request on alphagov/frontend
@leenagupte Good spot, thanks. I will remove the `.yaml` option for now.
leenagupte pushed 9 commits to landing-pages-backend-data-statistics-scaffold alphagov/frontend
- Add a model for the statistics block It's unclear exactly how the data from the CSV files will be used to display th... 7414e99
- Add a placeholder view to display the modeled statistics data. The block should render twice as two statistics have ... c6b5dc2
- WIP use chart component e6b5d9c
- Add a method to get the x-axis keys 31b122e
- Rename "rows" method in statistics block A new "rows" method will be created in the next commit cbbfbac
- Add a rows method to return a row for each y-axis variable e4aae75
- Use new rows method in the view 222e88b
- Make csv_rows method private and remove tests 4d721d3
- Refactor the rows method in the statistics block Divides the rows method to a small public rows method and a private... 3e54bb9
leenagupte pushed 30 commits to landing-pages-backend-data-statistics-scaffold alphagov/frontend
- Make the second column optional in two column layouts This is convenient for the case where we're only using the lef... cab6479
- Add quote block fac92c5
- Add hero block variant 605e139
- Add test content fa3d26e
- Adds a demo of a task (singular) type of landing-page The blocks that haven't been added yet have been commented out... 2b6ed55
- Merge pull request #4283 from alphagov/landing-page-task-singular-demo Add a demo of a task (singular) type of landi... f17b11e
- Resolve reflow issue Using a fixed height leads to reflow issues when zooming in around 170%. By setting a minimum h... 1c9242b
- Merge pull request #4286 from alphagov/add-hero-block-variant Add hero block variant b076720
- Add the skeleton of a "goals" page, as per the designs 2222ccc
- Align the main navigation content across pages baa4a5a
- Remove TODO comments - we already have a PR for these 81b239c
- Merge branch 'main' into optional-right-columns 6def00f
- Merge pull request #4274 from alphagov/optional-right-columns Make the second column optional in two column layouts 544f126
- Merge pull request #4273 from alphagov/landing-page-goals-demo Add the skeleton of a "goals" page, as per the designs 6433177
- Rename schema to schema_name 14f4584
- Pass content_item_hash to breadcrumb component 177b175
- Add 'See the latest data on our progress' link to homepage 88d3a56
- Merge pull request #4295 from alphagov/fix_breadcrumb_duplication Fix breadcrumb duplication 7f67002
- Merge pull request #4294 from alphagov/add-see-latest-data-link-to-homepage Add 'See the latest data on our progress... db9705a
- Add YAML content and data for a statistics block Statistics data will be read in from a CSV to be provided by depart... 030a5bc
- and 10 more ...
leenagupte pushed 1 commit to landing-pages-backend-data-statistics-scaffold alphagov/frontend
- Refactor the rows method in the statistics block Divides the rows method to a small public rows method and a private... 27996d2
leenagupte created a review comment on a pull request on alphagov/frontend
I think this should be `padding:` to pick up the value in `block.data["padding"]`, otherwise it will always be set to `true`. Is there a time when the padding shouldn't be set? I'm wondering if ...
leenagupte pushed 7 commits to landing-pages-backend-data-statistics-scaffold alphagov/frontend
- Separate rows method The original method was looking at rows and lines in the same thing. 0d547a2
- Use a map rather than an each in rows method 1525911
- Remove the index from lines method it's not being used. e13d7e8
- Return CSV rows with symbol keys Rather than using `to_sym` everywhere. 78c4c9a
- Use keys.first As `:Date` looks odd. 86142c9
- Use each with object 1ae9394
- Obfuscate the row key values We can't guarantee what the keys will be named so it's better not to rely on them. We'... f49841e
JamesCGDS created a comment on a pull request on alphagov/frontend
No worries @KludgeKML, all good 👍
KludgeKML created a comment on a pull request on alphagov/frontend
Thanks @JamesCGDS, sorry about the mix-up!
hannako pushed 1 commit to places_finder_fix alphagov/frontend
- Allow the button text to match the publication title Following a content review, it has been decided that on the Fin... 03e79f1
AshGDS opened a draft pull request on alphagov/frontend
Add basic heading block
⚠️ This repo is Continuously Deployed: make sure you [follow the guidance](https://docs.publishing.service.gov.uk/manual/development-pipeline.html#merge-your-own-pull-request) ⚠️ ## What / Why ...hannako pushed 2 commits to places_finder_fix alphagov/frontend
AshGDS created a branch on alphagov/frontend
heading-tweaks - Serves the homepage, transactions and some index pages on GOV.UK
matthillco opened a draft pull request on alphagov/frontend
Options for adding extra vertical spacing between blocks
⚠️ This repo is Continuously Deployed: make sure you [follow the guidance](https://docs.publishing.service.gov.uk/manual/development-pipeline.html#merge-your-own-pull-request) ⚠️ ## What Two ...matthillco created a branch on alphagov/frontend
landing-page-extra-margins - Serves the homepage, transactions and some index pages on GOV.UK
jon-kirwan pushed 2 commits to main alphagov/frontend
JamesCGDS pushed 3 commits to main alphagov/frontend
JamesCGDS closed a pull request on alphagov/frontend
Fix breadcrumb duplication
⚠️ This repo is Continuously Deployed: make sure you [follow the guidance](https://docs.publishing.service.gov.uk/manual/development-pipeline.html#merge-your-own-pull-request) ⚠️ ## What This...richardTowers created a review on a pull request on alphagov/frontend
Nice work - this looks like exactly the change I thought we'd need to make.
jon-kirwan created a comment on a pull request on alphagov/frontend
> Looks like the right solution, but could you add it to `/landing-page/homepage`? Check with backend if you're not sure which YML file that should be. Thanks for the review. Added to homepage.y...
jon-kirwan pushed 8 commits to add-see-latest-data-link-to-homepage alphagov/frontend
- Make the second column optional in two column layouts This is convenient for the case where we're only using the lef... cab6479
- Add the skeleton of a "goals" page, as per the designs 2222ccc
- Align the main navigation content across pages baa4a5a
- Remove TODO comments - we already have a PR for these 81b239c
- Merge branch 'main' into optional-right-columns 6def00f
- Merge pull request #4274 from alphagov/optional-right-columns Make the second column optional in two column layouts 544f126
- Merge pull request #4273 from alphagov/landing-page-goals-demo Add the skeleton of a "goals" page, as per the designs 6433177
- Add 'See the latest data on our progress' link to homepage 88d3a56