Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
algesten closed a pull request on algesten/str0m
Move openssl vendored featureflag to default
Some security requirements might be that a user must use system provided OpenSSL. Added a new feature called openssl-vendored which uses openssl feature and also add the vendored flag. Easy w...
xnorpx created a comment on a pull request on algesten/str0m
@algesten ok ready for review, tested all combinations
xnorpx created a comment on a pull request on algesten/str0m
> As it happens, someone just now submitted a PR to ureq that shows a slightly more elegant way of doing this. > > [algesten/ureq#866](https://github.com/algesten/ureq/pull/866) > > We can ha...
algesten created a review on a pull request on algesten/str0m
As it happens, someone just now submitted a PR to ureq that shows a slightly more elegant way of doing this. https://github.com/algesten/ureq/pull/866 We can have a `vendored` feature flag th...
xnorpx opened a pull request on algesten/str0m
Move openssl vendored featureflag to default
Some security requirements might be that a user must use system provided OpenSSL. This allows to remove the vendored feature that is set.
k0nserv created a comment on a pull request on algesten/str0m
> Is this based on libwebrtc's loss_based_bwe_v2 (https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc)? Yeah, i...
k0nserv created a review comment on a pull request on algesten/str0m
It's here https://chromium.googlesource.com/external/webrtc/+/14e2779a6ccdc67038ed2069a5732dd41617c6f0/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc#347 You can configure these over...
xnorpx created a review comment on a pull request on algesten/str0m
They probably have some secret protobuf reader hidden there for their use :)
k0nserv created a review comment on a pull request on algesten/str0m
This enables an optimisation where we reuse allocations, see `Scratch` `src/packet/bwe/mod.rs`. They are only 64 bytes in size so it didn't feel like a problem to make them copy. Maybe `Scratch...
k0nserv created a review comment on a pull request on algesten/str0m
> Are they configurable in google's impl? Yep
k0nserv created a review comment on a pull request on algesten/str0m
These are only needed for tests(we could guard them behind that cfg)
pthatcher created a comment on a pull request on algesten/str0m
Is this based on libwebrtc's loss_based_bwe_v2 (https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc)?
algesten created a review comment on a pull request on algesten/str0m
Yeah, let's just make it the way it will be.
algesten created a review comment on a pull request on algesten/str0m
Are they configurable in google's impl?
algesten created a review comment on a pull request on algesten/str0m
I think this was deliberate. The record is only in one place.
k0nserv created a comment on a pull request on algesten/str0m
Thanks for the feedback @xnorpx. I really should've created this as draft since I'm still working on it. I don't expect big changes, but the crate level configuration is particularly unfleshed out
k0nserv created a review comment on a pull request on algesten/str0m
Maybe this should just be called `enable_bwe_loss` and we can not in the comment that it's experimental. Then, when it becomes stable, we can default it to on