Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

adobe/spacecat-api-service

blefebvre created a review comment on a pull request on adobe/spacecat-api-service
```suggestion This endpoint can be used to delete an API key. The API key will be marked as deleted in the system and ```

View on GitHub

blefebvre created a review comment on a pull request on adobe/spacecat-api-service
```suggestion description: API key metadata returned successfully. Note that the API key itself will not be included in this list, as it's only displayed once (at creation). ```

View on GitHub

blefebvre created a review comment on a pull request on adobe/spacecat-api-service
Believe this will be an array of item type `object`.

View on GitHub

blefebvre created a review comment on a pull request on adobe/spacecat-api-service
Should `feature` be `features` instead, and an array? Thinking ahead to future use cases.

View on GitHub

blefebvre created a review comment on a pull request on adobe/spacecat-api-service
Do we need to call out these 3 in the docs?

View on GitHub

blefebvre created a review on a pull request on adobe/spacecat-api-service
Few comments for your consideration 👍

View on GitHub

blefebvre created a review on a pull request on adobe/spacecat-api-service
Few comments for your consideration 👍

View on GitHub

naydav pushed 1 commit to SITES-25573-debug adobe/spacecat-api-service
  • feat: SITES-25573 Enable/Disable domains for CWV audit via API/slack command -- debug 0105f3a

View on GitHub

naydav pushed 1 commit to SITES-25573-debug adobe/spacecat-api-service
  • feat: SITES-25573 Enable/Disable domains for CWV audit via API/slack command -- debug 81cc2c7

View on GitHub

naydav pushed 1 commit to SITES-25573-debug adobe/spacecat-api-service
  • feat: SITES-25573 Enable/Disable domains for CWV audit via API/slack command -- debug bb74828

View on GitHub

naydav pushed 3 commits to SITES-25573-debug adobe/spacecat-api-service
  • fix(deps): update dependency @adobe/spacecat-shared-data-access to v1.49.0 (#546) Co-authored-by: renovate[bot] <291... 9838ab7
  • chore(release): 1.73.2 [skip ci] ## [1.73.2](https://github.com/adobe/spacecat-api-service/compare/v1.73.1...v1.73.2... 19267ae
  • feat: SITES-25573 Enable/Disable domains for CWV audit via API/slack command -- debug f037d53

View on GitHub

swetabar created a review comment on a pull request on adobe/spacecat-api-service
Done.

View on GitHub

swetabar created a review on a pull request on adobe/spacecat-api-service

View on GitHub

swetabar pushed 1 commit to SITES-25915-api-spec-for-api-key-management adobe/spacecat-api-service
  • fix: Add changes based on review comments d60f406

View on GitHub

swetabar created a review comment on a pull request on adobe/spacecat-api-service
`deletedAt` will be an attribute in the ApiKeys table. We do not need to show it in the metadata response.

View on GitHub

swetabar created a review on a pull request on adobe/spacecat-api-service

View on GitHub

swetabar created a review comment on a pull request on adobe/spacecat-api-service
`x-api-key` needs to be removed.

View on GitHub

swetabar created a review on a pull request on adobe/spacecat-api-service

View on GitHub

swetabar created a review on a pull request on adobe/spacecat-api-service

View on GitHub

swetabar created a review comment on a pull request on adobe/spacecat-api-service
We list the expired key as part of the APIKeyMetadataResponse, but not the deleted keys.

View on GitHub

swetabar created a review on a pull request on adobe/spacecat-api-service

View on GitHub

blefebvre created a review comment on a pull request on adobe/spacecat-api-service
As discussed at standup, let's mirror how we've modelled scopes in the api-keys table.

View on GitHub

blefebvre created a review on a pull request on adobe/spacecat-api-service

View on GitHub

swetabar created a review comment on a pull request on adobe/spacecat-api-service
But, in this case, it shows the apiKey as null. ![Screenshot 2024-10-24 at 10 44 26 AM](https://github.com/user-attachments/assets/a7902357-6b40-4943-a553-1395c64a3ec6)

View on GitHub

swetabar created a review on a pull request on adobe/spacecat-api-service

View on GitHub

swetabar created a review comment on a pull request on adobe/spacecat-api-service
Something like this: ``` ApiKeyResponse: type: object properties: id: description: The ID of the API key $ref: '#/Id' name: description: The name of the API k...

View on GitHub

swetabar created a review on a pull request on adobe/spacecat-api-service

View on GitHub

swetabar created a review comment on a pull request on adobe/spacecat-api-service
Done.

View on GitHub

swetabar created a review on a pull request on adobe/spacecat-api-service

View on GitHub

swetabar created a review comment on a pull request on adobe/spacecat-api-service
Good point. I took a real one and modified the letters and alphabets.

View on GitHub

Load more