Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
swetabar created a review comment on a pull request on adobe/spacecat-api-service
I kept it as api-keys as we could use the same endpoint: /tools/api-keys for both post and get. `GET /tools/api-keys` retrieves all API keys created by a client.
atopper created a review comment on a pull request on adobe/spacecat-api-service
This looks like a legit id. Maybe use than obviously fake pattern to show an example: `[email protected]`
atopper created a review comment on a pull request on adobe/spacecat-api-service
This seems to refer (eventually) to a description of a single api-key. Was this internationally plural (`api-keys` vs `api-key`)?
swetabar created a review comment on a pull request on adobe/spacecat-api-service
Should deletedAt be part of the ApiKeyMetadataResponse? As `ApiKeyResponse` is shown only once - when the user creates an API Key.
swetabar created a review comment on a pull request on adobe/spacecat-api-service
I was thinking about it - should we keep it consistent everywhere? Move `domains` to `scopes` everywhere. Or move `domains` to a higher level everywhere (even in the database).
swetabar pushed 1 commit to SITES-25915-api-spec-for-api-key-management adobe/spacecat-api-service
- fix: Fix the indentation of parameters.yaml 67f2d98
swetabar created a review comment on a pull request on adobe/spacecat-api-service
I was thinking of modifying the ApiKeys table as well to make it more simplistic. Keep domains at a higher level. I'm open to re-think it.
swetabar created a review comment on a pull request on adobe/spacecat-api-service
Yes - can add a deletedAt, should work.
swetabar pushed 3 commits to SITES-25915-api-spec-for-api-key-management adobe/spacecat-api-service
- fix(deps): update dependency @adobe/spacecat-shared-data-access to v1.49.0 (#546) Co-authored-by: renovate[bot] <291... 9838ab7
- chore(release): 1.73.2 [skip ci] ## [1.73.2](https://github.com/adobe/spacecat-api-service/compare/v1.73.1...v1.73.2... 19267ae
- Merge branch 'main' into SITES-25915-api-spec-for-api-key-management cf9b601
swetabar created a review comment on a pull request on adobe/spacecat-api-service
Just to confirm that the apiKeyId requested is created by the user. Also, for simplicity - keeping the same header for all apiKey related requests.
dipratap opened a pull request on adobe/spacecat-api-service
fix: draft pr for workaround for scrape slackrole issue
Please ensure your pull request adheres to the following guidelines: - [ ] make sure to link the related issues in this description. Or if there's no issue created, make sure you describe here...
dipratap created a branch on adobe/spacecat-api-service
urgent_deploy - Edge Delivery services experience success as a service automation: SpaceCat + Star Catalogue
solaris007 created a comment on a pull request on adobe/spacecat-api-service
tada: This PR is included in version 1.73.2 :tada: The release is available on: - `v1.73.2` - [GitHub release](https://github.com/adobe/spacecat-api-service/releases/tag/v1.73.2) Your **[semantic...
solaris007 published a release on adobe/spacecat-api-service
v1.73.2
## [1.73.2](https://github.com/adobe/spacecat-api-service/compare/v1.73.1...v1.73.2) (2024-10-24) ### Bug Fixes * **deps:** update dependency @adobe/spacecat-shared-data-access to v1.49.0 ([#546...
solaris007 created a tag on adobe/spacecat-api-service
v1.73.2 - Edge Delivery services experience success as a service automation: SpaceCat + Star Catalogue
solaris007 pushed 1 commit to main adobe/spacecat-api-service
- chore(release): 1.73.2 [skip ci] ## [1.73.2](https://github.com/adobe/spacecat-api-service/compare/v1.73.1...v1.73.2... 19267ae
renovate[bot] pushed 1 commit to main adobe/spacecat-api-service
- fix(deps): update dependency @adobe/spacecat-shared-data-access to v1.49.0 (#546) Co-authored-by: renovate[bot] <291... 9838ab7
renovate[bot] closed a pull request on adobe/spacecat-api-service
fix(deps): update dependency @adobe/spacecat-shared-data-access to v1.49.0
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@adobe/spacecat-shared-data-access](https://redirect.github.com/ad...
github-actions[bot] created a comment on a pull request on adobe/spacecat-api-service
<!-- generated by: semantic-release-comment-action --> This PR will trigger **a patch release** when merged.
