Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
renovate[bot] opened a pull request on adobe/spacecat-api-service
fix(deps): update dependency @adobe/spacecat-shared-data-access to v1.49.0
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@adobe/spacecat-shared-data-access](https://redirect.github.com/ad...
blefebvre closed a draft pull request on adobe/spacecat-api-service
DEBUG: dump request object to debug log level
DRAFT: for illustration purposes. Not intended to be merged.
blefebvre created a review comment on a pull request on adobe/spacecat-api-service
Will this make it trickier (more error prone) to serialize from the api-keys table to this response DTO? I totally see the benefit of the higher level `features` prop and specifying domains at t...
swetabar pushed 1 commit to SITES-25915-api-spec-for-api-key-management adobe/spacecat-api-service
- Update docs/openapi/tools-api.yaml Co-authored-by: Bruce Lefebvre <[email protected]> 4cdc067
swetabar pushed 1 commit to SITES-25915-api-spec-for-api-key-management adobe/spacecat-api-service
- Update docs/openapi/tools-api.yaml Co-authored-by: Bruce Lefebvre <[email protected]> ee2938a
swetabar pushed 1 commit to SITES-25915-api-spec-for-api-key-management adobe/spacecat-api-service
- Update docs/openapi/tools-api.yaml Co-authored-by: Bruce Lefebvre <[email protected]> cd0b797
swetabar pushed 1 commit to SITES-25915-api-spec-for-api-key-management adobe/spacecat-api-service
- Update docs/openapi/responses.yaml Co-authored-by: Bruce Lefebvre <[email protected]> 0261bcf
swetabar created a review comment on a pull request on adobe/spacecat-api-service
They will be stored as an array of strings. Not as a map object as we are moving domains to a higher level.
blefebvre created a review comment on a pull request on adobe/spacecat-api-service
Is this necessary if we will receive the `apiKeyId` in the path?
blefebvre created a review comment on a pull request on adobe/spacecat-api-service
```suggestion will no longer be valid for authentication. Only keys created by this IMS client can be deleted by it. ```
blefebvre created a review comment on a pull request on adobe/spacecat-api-service
If the above `scopes` is an array of objects, then `imports.write` (or any other scope which needs it) will contain the domains information, so it wouldn't need to be duplicated here.
blefebvre created a review comment on a pull request on adobe/spacecat-api-service
```suggestion This endpoint can be used to list all the API keys created by the client. ```
blefebvre created a review comment on a pull request on adobe/spacecat-api-service
```suggestion summary: Get all API keys owned by the given IMS client ```
blefebvre created a review comment on a pull request on adobe/spacecat-api-service
```suggestion returned in the response only once. The scoped API key can be used to authenticate the Spacecat APIs by ```
blefebvre created a review comment on a pull request on adobe/spacecat-api-service
Does this type just hide the `apiKey` value? Any way we could accomplish this without the duplication?
blefebvre created a review comment on a pull request on adobe/spacecat-api-service
Do we need a `deletedAt` here as well, to handle when the user initiates a delete?
blefebvre created a review comment on a pull request on adobe/spacecat-api-service
Will this be an `object` type, as they are currently stored in the DB?
blefebvre created a review comment on a pull request on adobe/spacecat-api-service
```suggestion Forbidden. The maximum number of API keys that can be created per client has been exceeded. ```
blefebvre created a review comment on a pull request on adobe/spacecat-api-service
Indentation looks off here.
github-actions[bot] created a comment on a pull request on adobe/spacecat-api-service
<!-- generated by: semantic-release-comment-action --> This PR will trigger **no release** when merged.
blefebvre pushed 1 commit to blefebvr/request-dump adobe/spacecat-api-service
- DEBUG: dump request object to debug log level 8599898
naydav pushed 7 commits to SITES-25573-debug adobe/spacecat-api-service
- fix(deps): update external major (major) (#540) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.... ba47cae
- chore(release): 1.72.5 [skip ci] ## [1.72.5](https://github.com/adobe/spacecat-api-service/compare/v1.72.4...v1.72.5... 7fa4c00
- feat: Build end-to-end test suite which will be run daily (#542) 6a721b4
- chore(release): 1.73.0 [skip ci] # [1.73.0](https://github.com/adobe/spacecat-api-service/compare/v1.72.5...v1.73.0)... 951be48
- fix(deps): update dependency @adobe/spacecat-shared-utils to v1.21.0 (#543) Co-authored-by: renovate[bot] <29139614+... a35579e
- chore(release): 1.73.1 [skip ci] ## [1.73.1](https://github.com/adobe/spacecat-api-service/compare/v1.73.0...v1.73.1... f93710a
- Merge branch 'main' into SITES-25573-debug 6ce11d0
swetabar pushed 1 commit to SITES-25915-api-spec-for-api-key-management adobe/spacecat-api-service
- fix: remove newline 07d1952
github-actions[bot] created a comment on a pull request on adobe/spacecat-api-service
<!-- generated by: semantic-release-comment-action --> This PR will trigger **a minor release** when merged.
swetabar opened a pull request on adobe/spacecat-api-service
feat: [Sites-25915] API spec for api key management
Proposing 3 new endpoints: * `POST /tools/api-keys` - Create a new API Key * `GET /tools/api-keys` - Retrieve the API Key metadata for all API Keys created by the user * `DELETE /tools/api-keys/...
swetabar pushed 1 commit to SITES-25915-api-spec-for-api-key-management adobe/spacecat-api-service
- fix: Increase the unit test coverage 61ce4a0