Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
rspbot created a comment on a pull request on adobe/react-spectrum
<!-- APIDifferComment -->## API Changes ### @react-spectrum/s2 #### /@react-spectrum/s2:Dialog ```diff Dialog { UNSAFE_className?: string UNSAFE_style?: CSSProperties aria-describedby?:...
rspbot created a comment on a pull request on adobe/react-spectrum
Build successful! 🎉 * [View the storybook](https://reactspectrum.blob.core.windows.net/reactspectrum/d16962d2f75fffe5650d81d6517d771536fadd8b/storybook/index.html) * [View the storybook-19](ht...
devongovett created a review comment on a pull request on adobe/react-spectrum
also supporting arbitrary pixel sizes https://github.com/adobe/react-spectrum/pull/7385
LFDanLu created a review comment on a pull request on adobe/react-spectrum
hmm, I think those are pretty important so I'll put it right after the dialog summary blurb
LFDanLu pushed 1 commit to S2_release_notes adobe/react-spectrum
- exposing padding prop in CustomDialog docs d16962d
devongovett created a review comment on a pull request on adobe/react-spectrum
Not exactly sure where, but we should link to the new docs for style macro (color and typography) #7292 and optimizing CSS bundling #7278
rspbot created a comment on a pull request on adobe/react-spectrum
<!-- APIDifferComment -->## API Changes ### @react-spectrum/s2 #### /@react-spectrum/s2:Dialog ```diff Dialog { UNSAFE_className?: string UNSAFE_style?: CSSProperties aria-describedby?:...
LFDanLu created a review comment on a pull request on adobe/react-spectrum
I noticed that `padding` is removed from the props table in the storybook intentionally (probably because it makes the story look strange when applied), but are we worried about discoverablity?
rspbot created a comment on a pull request on adobe/react-spectrum
Build successful! 🎉 * [View the storybook](https://reactspectrum.blob.core.windows.net/reactspectrum/71bde5758b174c17ff9ae4875c391a26e421d114/storybook/index.html) * [View the storybook-19](ht...
rspbot created a comment on a pull request on adobe/react-spectrum
Build successful! 🎉 * [View the storybook](https://reactspectrum.blob.core.windows.net/reactspectrum/3354896a9b48abc25352b199f32463db995436de/storybook/index.html) * [View the storybook-19](ht...
majornista created a comment on a pull request on adobe/react-spectrum
> Interesting that this will fail even when `jest.setSystemTime` is in use > > out of curiosity, how'd you find this one? it's not failing on main right now and I don't quite follow your comment...
majornista pushed 6 commits to Issue-7228 adobe/react-spectrum
- chore: Update S2 Dialog codemods (#7388) * Rename isDismissable to isDismissible * Update Dialog codemod * Fix TS ... 8217bd4
- Improve error message for missing Provider error (#7404) 65e3a52
- chore: Add ActionButtonGroup and ToggleButtonGroup to example apps and tailwind starter kit (#7407) * Add ActionButt... 16153ed
- Document RAC Dialog close button slot (#7405) 62718d4
- feat: Add RAC example of Menu nested in popover dialog (#7402) * feat: Add RAC example of Menu nested in popover dia... baa330f
- fix: [BUG] - Autocomplete - Text selection with Shift + Home/End isn't working (#7228) Possible fix for #7228 3354896
majornista pushed 7 commits to Issue-7399 adobe/react-spectrum
- chore: Revert exactOptionalPropertyTypes id support (#7400) 52e167d
- chore: Update S2 Dialog codemods (#7388) * Rename isDismissable to isDismissible * Update Dialog codemod * Fix TS ... 8217bd4
- Improve error message for missing Provider error (#7404) 65e3a52
- chore: Add ActionButtonGroup and ToggleButtonGroup to example apps and tailwind starter kit (#7407) * Add ActionButt... 16153ed
- Document RAC Dialog close button slot (#7405) 62718d4
- feat: Add RAC example of Menu nested in popover dialog (#7402) * feat: Add RAC example of Menu nested in popover dia... baa330f
- fix(#7399): DatePicker.test fails with daylight savings change If the defaultValue is on daylight savings time and t... 71bde57
rspbot commented on a commit on adobe/react-spectrum
Verdaccio builds: [CRA Test App](https://reactspectrum.blob.core.windows.net/reactspectrum/62718d412fef43cdff70e490ea59752254d876fd/verdaccio/build/index.html) [NextJS Test App](https:/...
LFDanLu created a review comment on a pull request on adobe/react-spectrum
@yihuiliao right but the dialog api changes are S2 specific, I made the same assumptions haha hence I didn't really look at the canvas while writing these
LFDanLu created a review comment on a pull request on adobe/react-spectrum
oh doh, I conflated my work as the S2 release notes in general haha. I'm happy to pull yours in
yihuiliao created a review comment on a pull request on adobe/react-spectrum
I thought we had two release notes — one for RSP/RAC and then another one for S2. This PR seems to handle the S2 stuff and the canvas seems to be more for the RSP/RAC stuff?
rspbot created a comment on a pull request on adobe/react-spectrum
Build successful! 🎉 * [View the storybook](https://reactspectrum.blob.core.windows.net/reactspectrum/c581c65ef8f4f49790c3c2ae82f3c8f311562130/storybook/index.html) * [View the storybook-19](ht...
devongovett pushed 5 commits to actiongroup-codemods adobe/react-spectrum
- chore: Revert exactOptionalPropertyTypes id support (#7400) 52e167d
- chore: Update S2 Dialog codemods (#7388) * Rename isDismissable to isDismissible * Update Dialog codemod * Fix TS ... 8217bd4
- Improve error message for missing Provider error (#7404) 65e3a52
- Merge branch 'main' of github.com:adobe/react-spectrum into actiongroup-codemods # Conflicts: # packages/dev/codemod... ccedca0
- Fix Item and ActionGroup imports c581c65
github-merge-queue[bot] pushed 1 commit to main adobe/react-spectrum
- feat: Add RAC example of Menu nested in popover dialog (#7402) * feat: Add RAC example of Menu nested in popover dia... baa330f
