Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pivovarvalera opened a pull request on a-givertzman/va-sensor-emulator
VA-Sensor | Emulator | UdpMessage
pivovarvalera pushed 1 commit to 16-back-|-va-sensor-|-emulator-|-udpmessage a-givertzman/va-sensor-emulator
- VA-Sensor | Emulator | UdpMessage 40732ce
pivovarvalera opened a pull request on a-givertzman/va-sensor-emulator
VA-Sensor | Emulator | UdpHeader
pivovarvalera pushed 1 commit to 15-back-|-va-sensor-|-emulator-|-udpheader a-givertzman/va-sensor-emulator
- VA-Sensor | Emulator | UdpHeader 1a77d3f
pivovarvalera reopened an issue on a-givertzman/va-sensor-emulator
Back | VA-Sensor | Emulator | Udp
pivovarvalera opened an issue on a-givertzman/va-sensor-emulator
Back | VA-Sensor | Emulator | UdpMessage
pivovarvalera opened an issue on a-givertzman/va-sensor-emulator
Back | VA-Sensor | Emulator | UdpHeader
a-givertzman created a review comment on a pull request on a-givertzman/va-sensor-emulator
replace literal with SYN = 4, defined in the responsible class
a-givertzman created a review comment on a pull request on a-givertzman/va-sensor-emulator
match send result, just log if error for now
a-givertzman created a review comment on a pull request on a-givertzman/va-sensor-emulator
Replace literals with constants, defined in the responsible classes if possible.
a-givertzman created a review comment on a pull request on a-givertzman/va-sensor-emulator
Move to the `udp_header.rs` file - develop in the Issie-PR pair - may bee unit test ?
a-givertzman created a review comment on a pull request on a-givertzman/va-sensor-emulator
avoid empty lines in the code block
a-givertzman created a review comment on a pull request on a-givertzman/va-sensor-emulator
Move to the `udp_message.rs` file - develop in the Issie-PR pair - may bee unit test ?
a-givertzman pushed 2 commits to 13-back-|-va-sensor-|-emulator-|-mainservice a-givertzman/va-sensor-emulator
pivovarvalera pushed 1 commit to 13-back-|-va-sensor-|-emulator-|-mainservice a-givertzman/va-sensor-emulator
- VA-Sensor | Emulator | MainService 5eb47f8
a-givertzman created a review comment on a pull request on a-givertzman/va-sensor-emulator
try to avoid unsafe
a-givertzman created a review comment on a pull request on a-givertzman/va-sensor-emulator
I thought `src/buffer.rs` - was implemented exactly for accumulating with specified capacity like: ```rust match buf.add(amplitude) { Some() => { ... } None -> { ... ...
a-givertzman created a review comment on a pull request on a-givertzman/va-sensor-emulator
What does it mean? We are already inside `MainService` which is `&mut self` isn't it?
a-givertzman created a review comment on a pull request on a-givertzman/va-sensor-emulator
↑ prefer in style convenient // //
a-givertzman created a review comment on a pull request on a-givertzman/va-sensor-emulator
Doc comment required
a-givertzman created a review comment on a pull request on a-givertzman/va-sensor-emulator
Doc comment required
a-givertzman created a review comment on a pull request on a-givertzman/va-sensor-emulator
'message()' - can be used
a-givertzman created a review comment on a pull request on a-givertzman/va-sensor-emulator
empty lines is not required