Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
kaleb-keny created a review comment on a pull request on Synthetixio/synthetix-deployments
will fix these on sepolia too
kaleb-keny created a review comment on a pull request on Synthetixio/synthetix-deployments
yeah i misunderstood what you meant here, but now i do.... this should not have been committed 😅
kaleb-keny pushed 1 commit to sccp-357-base-mainnet Synthetixio/synthetix-deployments
- Revert "Update tomls/omnibus-base-mainnet-andromeda/collaterals/synth-cbbtc.toml" This reverts commit cc5bd83a6d2b4e... db2ba8f
kaleb-keny pushed 1 commit to sccp-357-sepolia Synthetixio/synthetix-deployments
- make-it-pretty-please 6893ace
kaleb-keny pushed 1 commit to sccp-357-sepolia Synthetixio/synthetix-deployments
- make weth great again 98bfaa4
kaleb-keny created a review comment on a pull request on Synthetixio/synthetix-deployments
alright will revise then, no worries,
noisekit created a review comment on a pull request on Synthetixio/synthetix-deployments
I realised there are more things. 1. Frontend cannot rely on weth being weth and do normal wrapping workflow and will have to treat it differently for testnet. 2. e2e tests will need to differ f...
kaleb-keny created a review comment on a pull request on Synthetixio/synthetix-deployments
But if you really really feel otherwise about it, happy to make the necessary updates ofc,
kaleb-keny created a review comment on a pull request on Synthetixio/synthetix-deployments
yeah alright please let's keep this as fake weth 🙏🏼 it helps those who need to use the chain for testing, has no net negative, the supply of these tokens is being constrained.... so hopefully no o...
noisekit created a review comment on a pull request on Synthetixio/synthetix-deployments
It probably is down to our context. I do all the testing in anvil. So getting weth is just `.deposit({value: whatever})` (because we have unlimited ETH) and all our tests are using real ETH -> WETH...
kaleb-keny pushed 2 commits to sccp-357-base-mainnet Synthetixio/synthetix-deployments
kaleb-keny created a review comment on a pull request on Synthetixio/synthetix-deployments
It's used in collateral configuration, with `sc_pool_id` only
kaleb-keny created a review comment on a pull request on Synthetixio/synthetix-deployments
also why setting 😅 ?
kaleb-keny created a review comment on a pull request on Synthetixio/synthetix-deployments
yeah this will cause issues if we change it? It's not referenced anywhere with `spartan_council_pool_id_setting` ?
kaleb-keny pushed 1 commit to sccp-357-base-mainnet Synthetixio/synthetix-deployments
- Update tomls/omnibus-base-mainnet-andromeda/collaterals/synth-cbbtc.toml Co-authored-by: Noisekit <28145325+noisekit... cc5bd83
kaleb-keny pushed 1 commit to sccp-357-base-mainnet Synthetixio/synthetix-deployments
- Update tomls/omnibus-base-mainnet-andromeda/rewards/scbeth_perps_liquidations_rewards.toml Co-authored-by: Noisekit ... e286047
kaleb-keny pushed 1 commit to sccp-357-base-mainnet Synthetixio/synthetix-deployments
- Update tomls/omnibus-base-mainnet-andromeda/rewards/sweth_perps_liquidations_rewards.toml Co-authored-by: Noisekit <... 2e23006
kaleb-keny created a review comment on a pull request on Synthetixio/synthetix-deployments
Well that almost caused an issue @noisekit , thankfully fixed 😅 missing `s` sir
kaleb-keny pushed 2 commits to sccp-357-sepolia Synthetixio/synthetix-deployments