Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
batcheu opened a pull request on Samsung/ONE
[tools/mec] Add quantization parameters to tensor information
If the model is quantized, it will show quantization parameters of each tensors. --- * issue : #14368
jinevening created a review on a pull request on Samsung/ONE
LGTM The interface seems a bit tricky to use, but I guess it may be wrapped by other functions in python.
mhs4670go created a review comment on a pull request on Samsung/ONE
Here's the python codes. ```python def check_for_errors(): error_message = ffi.string(C.get_last_error()).decode('utf-8') if error_message: C.clear_last_error() raise RuntimeError...
jinevening created a review comment on a pull request on Samsung/ONE
What are these functions for? Is it used in Python-side? If so, could you show the Python codes too?
mhs4670go created a comment on a pull request on Samsung/ONE
With patched codes, the error message prints like this. ```bash $ python eval.py C++ Exception: Invalid input size: 12 != 2 ```
jinevening created a review comment on a pull request on Samsung/ONE
How about adding an exception if output_size != getTensorSize(output_node) ?
jinevening created a review comment on a pull request on Samsung/ONE
Why doesn't `writeInputTensor` have `data_size` argument? `readOutputTensor` has output_size argument.
chunseoklee created a comment on a pull request on Samsung/ONE
@tomdol How about keeping this as it is since 1) This layer is correct 2) library other than eigen might use this layout I suggest to add notes about notifying "this layout is not used in G...
mhs4670go created a comment on a pull request on Samsung/ONE
> Q) any plans for unit tests ? I'll add a test.
batcheu opened a pull request on Samsung/ONE
[tools/mec] Fix module name in HOWTO
Since module name was changed from 'circle_adapter' to 'module_explorer_circle', it also needs to update the extension name in HOWTO. --- * Related w/ : #14365
mhs4670go created a review comment on a pull request on Samsung/ONE
Good point. I'll add an exception handling logic.
tomdol created a comment on a pull request on Samsung/ONE
Related: - https://github.com/Samsung/ONE/pull/14370 - https://github.com/Samsung/ONE/pull/14238#discussion_r1851466333
tomdol opened a pull request on Samsung/ONE
[compute/cker] Remove the storage order parametrization from BatchMatMul
This commit removes the obsolete parametrization of the BatchMatMul x86 optimized kernel. The reason is that the storage order attribute of the MatrixParams class is later ignored by the x86 Gemm i...
tomdol created a comment on a pull request on Samsung/ONE
Benchmark results in release mode ``` -------------------------------------------------------------------- Benchmark Time CPU Iterations -----------------...
tomdol created a review comment on a pull request on Samsung/ONE
I have some results that I described here https://github.com/Samsung/ONE/pull/14370 but long story short - this field doesn't matter for Gemm with Eigen so I believe setting of the `order` field co...
tomdol opened a draft pull request on Samsung/ONE
[cker] Storage order testing
Some benchmarking for https://github.com/Samsung/ONE/pull/14238#discussion_r1851466333 I've done some research to verify how things work and here are my most important findings: ## MatrixPara...
mbencer created a comment on a pull request on Samsung/ONE
@hseok-oh If you find a moment please take a look ;)
mbencer created a comment on a pull request on Samsung/ONE
> > @mbencer Please add negative test: same or more negative test with positive test to fulfill release criteria. > > I see the argument about release criteria. Due to fact that compilation/infe...
mhs4670go created a comment on an issue on Samsung/ONE
I've decided to use CFFI instead of ctypes. CFFI seems to show better performance.
seanshpark created a review comment on a pull request on Samsung/ONE
optional) ```suggestion } // extern "C" ```
