Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mzedel created a comment on a pull request on NorthernTechHQ/nt-gui
Thanks @aleksandrychev and @mineralsfree for checking this!! I'll address the things you mentioned, but also want to invite you to adjust this to whatever you think should be in here/ left out/ enf...
mzedel created a review comment on a pull request on NorthernTechHQ/nt-gui
this should have been caught by CI - will add a check for this!
mzedel created a review comment on a pull request on NorthernTechHQ/nt-gui
most likely not - it's more of a best effort for the onboarding time, but we don't have backend support for this to be usable for larger datasets 😞...
mzedel created a review comment on a pull request on NorthernTechHQ/nt-gui
the `commonErrorHandler` would create a snackbar, but here it's ok to get some errors (e.g. when running OS on-prem) - so logging it just in case 🤷♂️ - but that we can of course change later on!
mineralsfree created a review on a pull request on NorthernTechHQ/nt-gui
I think we should start using name conventions for utils/store and components : CamelCase for React components and pascalCase for utils and other files to improve readability
mineralsfree created a review on a pull request on NorthernTechHQ/nt-gui
I think we should start using name conventions for utils/store and components : CamelCase for React components and pascalCase for utils, other files to improve readability
mineralsfree created a review comment on a pull request on NorthernTechHQ/nt-gui
"@typescript-eslint/ban-ts-comment": "off", "@typescript-eslint/no-explicit-any": "warn"
mineralsfree created a review comment on a pull request on NorthernTechHQ/nt-gui
We should probably include this 2 as well "plugin:@typescript-eslint/eslint-recommended", "plugin:@typescript-eslint/recommended"
aleksandrychev created a review comment on a pull request on NorthernTechHQ/nt-gui
do we need console.log here or commonErrorHandler?
aleksandrychev created a review comment on a pull request on NorthernTechHQ/nt-gui
'virtual' and 'physical' might be moved into constants, I see them in different places
aleksandrychev created a review comment on a pull request on NorthernTechHQ/nt-gui
```suggestion ``` I guess not needed?
aleksandrychev created a review comment on a pull request on NorthernTechHQ/nt-gui
so, it gets first 200 devices for type processing. enough for larger datasets?
aleksandrychev created a review on a pull request on NorthernTechHQ/nt-gui
overall looks good and solid 👍
aleksandrychev created a review on a pull request on NorthernTechHQ/nt-gui
overall looks good and solid 👍