Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mikenairn pushed 5 commits to sotw_dnspolicy Kuadrant/kuadrant-operator
- tests: Disable all output capture in ginkgo tests This creates a lot of extra output during the test runs which is r... 93b7e35
- tests: Add --race option to ginkgo run This will cause the test suite to fail if any race condition is detected duri... aa8faf9
- tests: Improve test run output * Add verbose option to test runs so you can see the tests being executed. * Stop w... 7291a99
- dev: Add `--race` option to `make run` task Enables the race detector on locally running instances https://go.dev/do... 8c75fdc
- fix: go mod update bump policy-machinery module https://github.com/Kuadrant/policy-machinery/pull/45 Signed-off-by:... f9f0424
david-martin created a review comment on a pull request on Kuadrant/kuadrant-operator
Good catch. I think i'll call that out here, but keep the 2nd link as well as it's a more 'more details' and official way of accessing thanos-querier.
david-martin created a comment on an issue on Kuadrant/kuadrant-operator
When labels are changed, please also update the ServiceMonitors as needed to ensure they target the correct Services. See https://github.com/Kuadrant/kuadrant-operator/pull/953#discussion_r1814655...
david-martin created a review comment on a pull request on Kuadrant/kuadrant-operator
Consistency is important to avoid confusion, so +1 for that issue. I believe the monitor targets both services, so metrics would all be scraped (so the suggested monitors should work). I'll link ...
david-martin created a review comment on a pull request on Kuadrant/kuadrant-operator
These look generated by kubebuilder/kustomize. I don't see any harm in having them
mikenairn pushed 1 commit to sotw_dnspolicy Kuadrant/kuadrant-operator
- tests: Add --race option to ginkgo run This will cause the test suite to fail if any race condition is detected duri... 03a7af9
maleck13 created a comment on an issue on Kuadrant/kuadrant-operator
@mikenairn @guicassolato seeing this with DNSPolicy with state of the world Also notice the status is still set as enforced and accepted
roivaz created a review comment on a pull request on Kuadrant/kuadrant-operator
Yes, I have tested this in OCP with UWM and works as expected.
mikenairn pushed 1 commit to sotw_dnspolicy Kuadrant/kuadrant-operator
- tests: Remove all TestMain from suites Signed-off-by: Michael Nairn <[email protected]> a01c65e
jsmolar created a review comment on a pull request on Kuadrant/kuadrant-operator
Thanos datasource setup is also described in `install Grafana on OpenShifte guide.
jsmolar created a review comment on a pull request on Kuadrant/kuadrant-operator
The HTTPRoute must include the service and deployment labels, which are marked as "Important" in the dashboard. I believe we should mention this here as well. If the user follows this guide and imp...
jsmolar created a review comment on a pull request on Kuadrant/kuadrant-operator
Maybe we should provide link to `Secure, protect, and connect`
jsmolar created a review comment on a pull request on Kuadrant/kuadrant-operator
Is it required to use an extended amount of labels for the DNS monitor?
jsmolar created a review comment on a pull request on Kuadrant/kuadrant-operator
this `matchLabel` is the same as for kuadrant. This can be a problem for monitor to target correct service. I created an [issue for this](https://github.com/Kuadrant/kuadrant-operator/issues/846), ...
david-martin created a review comment on a pull request on Kuadrant/kuadrant-operator
I have a similar looking 'additionalScrapeConfig' [here](https://github.com/Kuadrant/kuadrant-operator/blob/main/config/observability/prometheus/additional-scrape-configs.yaml) but it doesn't work ...
roivaz created a review comment on a pull request on Kuadrant/kuadrant-operator
Ah, here is the source https://github.com/istio-ecosystem/sail-operator/blob/main/docs/README.md#observability-integrations Sail documentation, not Istio's.
roivaz created a review on a pull request on Kuadrant/kuadrant-operator
Just a couple of comments, looks good overall.
david-martin created a review comment on a pull request on Kuadrant/kuadrant-operator
Good point. I'll split this out and explain better with a warning.
roivaz created a review comment on a pull request on Kuadrant/kuadrant-operator
This can be done using a single PodMonitor that targets all your Gateways because Istio annotates the gateway pods with the port where the metrics are served. It's slightly convoluted though, but h...