Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
roivaz created a review comment on a pull request on Kuadrant/kuadrant-operator
This is not strictly necessary to have request metrics in Istio, those are enabled by default. This Telemetry configuration adds the request path as a label to the request metrics, which is not alw...
mikenairn pushed 1 commit to sotw_dnspolicy Kuadrant/kuadrant-operator
- tests: Disable all output capture in integration tests Signed-off-by: Michael Nairn <[email protected]> 106943e
maksymvavilov created a review comment on a pull request on Kuadrant/kuadrant-operator
I understand now, thanks! This sotw thing is weird
mikenairn created a branch on Kuadrant/kuadrant-operator
sotw_dnspolicy - The Operator to install and manage the lifecycle of the Kuadrant components deployments.
KevFan created a review comment on a pull request on Kuadrant/kuadrant-operator
> hasAttachedRoute is set to true only when we find the listener with the desired name and [defaults to false](https://github.com/Kuadrant/kuadrant-operator/pull/937/files#diff-b6f99dd8a13a65bd856d...
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
There will be additional changes to the API if/when we add section name, but it will be minimal.
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
Yes, this should allow section name to be added without new changes to this task. I have already got this working and will create a separate PR for that after this one is merged.
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
possibly not here since its not actually calculating anything additional to add into the log statements (probably was at one point and i removed it)
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
> Since the `hasAttachedRoute` will always use the last `Listener` in the status block, this can be incorrect since this bool value also help to set `gatewayHasAttachedRoutes ` 🤔 I'm still not r...
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
sure, it's not really much bigger than what we had previously, but it could probably benefit from a refactor of sorts. I would do that after though.
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
You don't really, this iterates around all polices ensuring there status is correct. Majority of times this will do nothing, but if any changes are detected in the topology related to a policy, rec...
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
I'll defer that question to @philbrookes who added it. I'm only removing code from this file in this PR, this already exists.
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
If you are referring to `controller.Destruct(policy)`, this is just converting it to a `unstructured.Unstructured` type so it works with the client https://github.com/Kuadrant/policy-machinery/blob...
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
Yes it probably could be. Same code as RLP for consistency https://github.com/Kuadrant/kuadrant-operator/blob/main/controllers/ratelimit_workflow.go#L267-L280
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
In this PR i am deliberately not moving code that i don't need to so i don't have to deal with a review of existing code. I will be following this PR up with another to remove some of the existing ...
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
This even this on the validation task of the policy so i don't believe this is required here. No change to the record will cause the policy to be invalidated.