Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
If you passed on in you would, but where its being used it would never not be. That said, we don't want to return an error in this case as the errors returned from this function are supposed to be ...
maleck13 created a comment on a pull request on Kuadrant/kuadrant-operator
@mikenairn I did a bunch of addiitonal manual tests with multiple gateways, multiple httproutes, deleting httproutes, deleting gateways, no credentials etc all worked as expected 👍 /lgtm
alexsnaps created a review comment on a pull request on Kuadrant/kuadrant-operator
I guess you're talking about [`HTTPQueryParamMatch`](https://gateway-api.sigs.k8s.io/reference/spec/#gateway.networking.k8s.io/v1.HTTPQueryParamMatch), right? So we'd ideally provide some means to ...
guicassolato pushed 2 commits to sotw/auth Kuadrant/kuadrant-operator
- activate auth service in the wasm config Signed-off-by: Guilherme Cassolato <[email protected]> 57e1cee
- check status of the authconfigs for the authpolicy enforced status condition + refactoring of the ratelimitpolicy sta... d06b3d3
guicassolato pushed 1 commit to sotw/auth Kuadrant/kuadrant-operator
- sotw: auth * AuthPolicies validation * Effective auth policies * Authorino AuthConfigs * Istio/Envoy Gateway cluster... 6236679
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
Now that the lookup key to select the AuthConfig will be tightly associated with the route (i.e hostname + all other HTTP attributes), I don't see much value in adding route conditions at the top-l...
codecov[bot] created a comment on a pull request on Kuadrant/kuadrant-operator
## [Codecov](https://app.codecov.io/gh/Kuadrant/kuadrant-operator/pull/954?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term...
eguzki created a comment on a pull request on Kuadrant/kuadrant-operator
tests are expected to fail because the base branch `install-sail-tp` needs to be rebased. The base branch needs to pick the fix of the authorino-operator deployment
eguzki opened a pull request on Kuadrant/kuadrant-operator
Istio installed using Sail operator added to integration tests
Additionally, istio default intallation tool in dev environments now it is Sail Operator
eguzki created a branch on Kuadrant/kuadrant-operator
install-sail-tp-eguzki - The Operator to install and manage the lifecycle of the Kuadrant components deployments.
codecov[bot] created a comment on a pull request on Kuadrant/kuadrant-operator
## [Codecov](https://app.codecov.io/gh/Kuadrant/kuadrant-operator/pull/953?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term...
david-martin opened a pull request on Kuadrant/kuadrant-operator
Update steps for setting up metrics on openshift, focusing on single …
…cluster - combine service monitors for operators for easier deploy - update openshift install steps to reference this file and explain the setup better - remove reference to multi cluster tha...
david-martin created a branch on Kuadrant/kuadrant-operator
update-obs-on-openshift-doc - The Operator to install and manage the lifecycle of the Kuadrant components deployments.
maleck13 created a review on a pull request on Kuadrant/kuadrant-operator
few minor things. But generally changes look ok and approachable. Will try it out locally but happy to approve
guicassolato pushed 3 commits to sotw/auth Kuadrant/kuadrant-operator
- dep: bump policy machinery to v0.6.0 (#950) Signed-off-by: KevFan <[email protected]> b771a77
- Prepare AuthPolicy type for the merge strategy * Structure of named patterns changed from `patterns: map[string][]Pa... 2670b85
- sotw: auth * AuthPolicies validation * Effective auth policies * Authorino AuthConfigs * Istio/Envoy Gateway cluster... d90b343
maleck13 created a review comment on a pull request on Kuadrant/kuadrant-operator
worth info logging here (orphan record being removed as no targets remain)?
maleck13 created a review comment on a pull request on Kuadrant/kuadrant-operator
so with this do we get section name support then?
maleck13 created a review comment on a pull request on Kuadrant/kuadrant-operator
this is one massive for loop :) wondering should we (in a follow up) split it into a set of function calls if possible and reduce the congnitive overhead (at least in reviews)
maleck13 created a review comment on a pull request on Kuadrant/kuadrant-operator
do we need this? I see it being used elsewhere without this check
maleck13 created a review comment on a pull request on Kuadrant/kuadrant-operator
```suggestion if recordExists { ```