Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
maleck13 created a review comment on a pull request on Kuadrant/kuadrant-operator
is it expected we will get non DNSPolicies? or should there be an error returned?
maleck13 created a review comment on a pull request on Kuadrant/kuadrant-operator
I can copy this change over if it is the only API change we expect
KevFan created a review comment on a pull request on Kuadrant/kuadrant-operator
Yeah, this is a `status` per `Listener` defined in the `Gateway` so I guess it's possible to have multiple `Listeners` and only a `Route` attached to just one of the `Listener` using the route `sec...
KevFan created a review comment on a pull request on Kuadrant/kuadrant-operator
Can we move this outside the loop since we I'm assuming we only need to get this once overall? 🤔
KevFan created a review comment on a pull request on Kuadrant/kuadrant-operator
Think we can use `topology.Targetables().Children(policy)` here to get the `Targetables` of a `Policy` which would make this a bit simpler 🤔 ```suggestion func (r *EffectiveDNSPoliciesReconciler...
Boomatang created a review comment on a pull request on Kuadrant/kuadrant-operator
Ya that is fair. I think the less we change how it previously worked the better. Should there be a ticket created to address this and possible other things that were required because of the ACM sup...
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
This is existing code that has been around for a while https://github.com/Kuadrant/kuadrant-operator/blob/main/controllers/dnspolicy_dnsrecords.go#L83-L87. I would be surprised if you can have more...
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
Removed the predicates
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
This is updated now
KevFan created a review on a pull request on Kuadrant/kuadrant-operator
First look through. Looks good overall 👍 Left some comments / minor nits (that do not have to be addressed in this PR unless you deem it necessary) 🧑💻
KevFan created a review on a pull request on Kuadrant/kuadrant-operator
First look through. Looks good overall 👍 Left some comments / minor nits (that do not have to be addressed in this PR unless you deem it necessary) 🧑💻
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
Fair point, but i don't really think we want to add this to the topology. I was actually wondering when i was having to update this, if we even need it any more. It was required when we support...
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
Changed this by adding a Validate method to the policy itself.
maleck13 pushed 1 commit to v1-dns-tls Kuadrant/kuadrant-operator
- v1 dnspolicy and tlspolicy api Signed-off-by: craig <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commi... c51a8f5
alexsnaps created a comment on an issue on Kuadrant/kuadrant-operator
Right, plus there is no benefit in treating the two differently, more so that they look exactly the same! Question is, how do we send the data when: ``` counters: - expression: request ``...
eguzki created a comment on an issue on Kuadrant/kuadrant-operator
I was thinking on a simple selector for counters. Yes. But maybe we can leverage CEL to do some transformations ```yaml counters: - dayOfTheWeek(request.time) ``` Could be handy
