Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
guicassolato closed an issue on Kuadrant/kuadrant-operator
[state-of-the-world reconciler] Effective policy RateLimit
Reconciliation of effective policies for rate limit. Update of Limitador CR for each applicable paths in the topology graph (Gateway → Gateway Listener → HTTPRoute → HTTPRouteRule). Special atte...
guicassolato closed a pull request on Kuadrant/kuadrant-operator
sotw: rlp workflow
State-of-the-world reconciler – RLP workflow - [x] `spec.targetRef.sectionName` - [x] `spec.(defaults|overrides).strategy` - [x] Defaults & Overrides merge strategies ([RFC-0009](https://docs....
guicassolato pushed 60 commits to sotw/rlp Kuadrant/kuadrant-operator
- sotw: effective ratelimitpolicy - ratelimit workflow - ratelimitopolicies validator - effective ratelimitpolicies re... e7d4a67
- removed unused function to apply rlp overrides Signed-off-by: Guilherme Cassolato <[email protected]> 9e21c61
- istio extension (WasmPlugin) reconciler Signed-off-by: Guilherme Cassolato <[email protected]> 688be2c
- fixup: unique limit definitions per scope Signed-off-by: Guilherme Cassolato <[email protected]> 1cbf4c9
- fixup: log error only when indeed there's an error to be logged Signed-off-by: Guilherme Cassolato <guicassolato@gma... 7d0b7e9
- do not fail when missing kuadrant object Signed-off-by: Guilherme Cassolato <[email protected]> e60aed0
- fixup: equality between wasmplugins and avoid rebuilding wasm config from struct when nil Signed-off-by: Guilherme C... 962510d
- fixup: error comparison Signed-off-by: Guilherme Cassolato <[email protected]> 77158b3
- cleanup istio extension objects when it cannot calculate effective policies Signed-off-by: Guilherme Cassolato <guic... d9256ab
- refactor: removal of SortablePolicy for sorting policies objects by creation timestamp Signed-off-by: Guilherme Cass... 8d4414a
- remove no longer relevant integration test case Signed-off-by: Guilherme Cassolato <[email protected]> 78c2175
- fixup: avoid updating invalid rate limit policies to 'accepted' on events that do not (re)validate policies Signed-o... fe28e06
- fixup: continue istio extension workflow when it fails for a given gateway Signed-off-by: Guilherme Cassolato <guica... 42846b9
- Remove unnused event recorder from base reconciler Signed-off-by: Guilherme Cassolato <[email protected]> 0b30d5b
- Istio rate limit cluster reconciler Signed-off-by: Guilherme Cassolato <[email protected]> a3b646e
- enable Istio-related rate limit tasks only when Istio is installed Signed-off-by: Guilherme Cassolato <guicassolato@... 6db892f
- ensure at least one hostname per wasm config policy Signed-off-by: Guilherme Cassolato <[email protected]> 1e57ef4
- bump istio to 1.22 Signed-off-by: Guilherme Cassolato <[email protected]> 063390e
- Use targetRefs to attach to gateways in the Istio EnvoyFilter and WasmPlugin resources Signed-off-by: Guilherme Cass... 30b13cd
- refactor: debug log messages for when Limitador, EnvoyFilter and WasmPlugins are up to date already and therefore not... ebbdf9f
- and 40 more ...
guicassolato pushed 61 commits to sotw/rlp Kuadrant/kuadrant-operator
- Authpolicy/v1beta3 (#924) * ADD: AuthPolicy v1beta3 First pass at adding v1beta3. This is not expected to compil... d981b16
- sotw: effective ratelimitpolicy - ratelimit workflow - ratelimitopolicies validator - effective ratelimitpolicies re... 0daf096
- removed unused function to apply rlp overrides Signed-off-by: Guilherme Cassolato <[email protected]> cbd7c8f
- istio extension (WasmPlugin) reconciler Signed-off-by: Guilherme Cassolato <[email protected]> 961d1af
- fixup: unique limit definitions per scope Signed-off-by: Guilherme Cassolato <[email protected]> d543472
- fixup: log error only when indeed there's an error to be logged Signed-off-by: Guilherme Cassolato <guicassolato@gma... 09de834
- do not fail when missing kuadrant object Signed-off-by: Guilherme Cassolato <[email protected]> 295a74b
- fixup: equality between wasmplugins and avoid rebuilding wasm config from struct when nil Signed-off-by: Guilherme C... cf6641c
- fixup: error comparison Signed-off-by: Guilherme Cassolato <[email protected]> 5bec74d
- cleanup istio extension objects when it cannot calculate effective policies Signed-off-by: Guilherme Cassolato <guic... 53600d9
- refactor: removal of SortablePolicy for sorting policies objects by creation timestamp Signed-off-by: Guilherme Cass... 2a5918a
- remove no longer relevant integration test case Signed-off-by: Guilherme Cassolato <[email protected]> 83c5559
- fixup: avoid updating invalid rate limit policies to 'accepted' on events that do not (re)validate policies Signed-o... 445d848
- fixup: continue istio extension workflow when it fails for a given gateway Signed-off-by: Guilherme Cassolato <guica... 3bb73a3
- Remove unnused event recorder from base reconciler Signed-off-by: Guilherme Cassolato <[email protected]> 54ff2ed
- Istio rate limit cluster reconciler Signed-off-by: Guilherme Cassolato <[email protected]> eccd661
- enable Istio-related rate limit tasks only when Istio is installed Signed-off-by: Guilherme Cassolato <guicassolato@... e0d4f84
- ensure at least one hostname per wasm config policy Signed-off-by: Guilherme Cassolato <[email protected]> 1db7684
- bump istio to 1.22 Signed-off-by: Guilherme Cassolato <[email protected]> 83f8c7f
- Use targetRefs to attach to gateways in the Istio EnvoyFilter and WasmPlugin resources Signed-off-by: Guilherme Cass... 2b9661f
- and 41 more ...
Boomatang closed an issue on Kuadrant/kuadrant-operator
AuthPolicy v1beta3
Bump version of the AuthPolicy API to v1beta3 containing the following changes: - Implement [`machinery.Policy`](https://github.com/Kuadrant/policy-machinery/blob/01dce39b8d969a3997f0d4ab5186656b3...
Boomatang closed a pull request on Kuadrant/kuadrant-operator
Authpolicy/v1beta3
Closes: https://github.com/Kuadrant/kuadrant-operator/issues/809 This change introduces the AuthPolicy v1beta3. The RouteSelector has being removed from the API. There is still work required ...
guicassolato created a comment on a pull request on Kuadrant/kuadrant-operator
> @guicassolato using sed would be the fastest way to do this, but there is reference to the route selectors in the guides. So it is not just a matter of doing a find and replace. I will work on th...
Boomatang created a comment on a pull request on Kuadrant/kuadrant-operator
@guicassolato using sed would be the fastest way to do this, but there is reference to the route selectors in the guides. So it is not just a matter of doing a find and replace. I will work on that...
guicassolato pushed 61 commits to sotw/rlp Kuadrant/kuadrant-operator
- refactor: effective tls policies reconciler (#927) * refactor: effective tls policies reconciler Signed-off-by: K... aba1a78
- sotw: effective ratelimitpolicy - ratelimit workflow - ratelimitopolicies validator - effective ratelimitpolicies re... 499f642
- removed unused function to apply rlp overrides Signed-off-by: Guilherme Cassolato <[email protected]> 9d979fc
- istio extension (WasmPlugin) reconciler Signed-off-by: Guilherme Cassolato <[email protected]> c8ef194
- fixup: unique limit definitions per scope Signed-off-by: Guilherme Cassolato <[email protected]> 9c82c00
- fixup: log error only when indeed there's an error to be logged Signed-off-by: Guilherme Cassolato <guicassolato@gma... 32bf8b5
- do not fail when missing kuadrant object Signed-off-by: Guilherme Cassolato <[email protected]> a0b9593
- fixup: equality between wasmplugins and avoid rebuilding wasm config from struct when nil Signed-off-by: Guilherme C... 8093665
- fixup: error comparison Signed-off-by: Guilherme Cassolato <[email protected]> 695a972
- cleanup istio extension objects when it cannot calculate effective policies Signed-off-by: Guilherme Cassolato <guic... eae81a3
- refactor: removal of SortablePolicy for sorting policies objects by creation timestamp Signed-off-by: Guilherme Cass... e686bd3
- remove no longer relevant integration test case Signed-off-by: Guilherme Cassolato <[email protected]> 3dda160
- fixup: avoid updating invalid rate limit policies to 'accepted' on events that do not (re)validate policies Signed-o... e61506f
- fixup: continue istio extension workflow when it fails for a given gateway Signed-off-by: Guilherme Cassolato <guica... f57c2ff
- Remove unnused event recorder from base reconciler Signed-off-by: Guilherme Cassolato <[email protected]> 00e7f43
- Istio rate limit cluster reconciler Signed-off-by: Guilherme Cassolato <[email protected]> 2957f0d
- enable Istio-related rate limit tasks only when Istio is installed Signed-off-by: Guilherme Cassolato <guicassolato@... 0362845
- ensure at least one hostname per wasm config policy Signed-off-by: Guilherme Cassolato <[email protected]> 0d70197
- bump istio to 1.22 Signed-off-by: Guilherme Cassolato <[email protected]> d33e319
- Use targetRefs to attach to gateways in the Istio EnvoyFilter and WasmPlugin resources Signed-off-by: Guilherme Cass... 48ce3b8
- and 41 more ...
KevFan pushed 1 commit to main Kuadrant/kuadrant-operator
- refactor: effective tls policies reconciler (#927) * refactor: effective tls policies reconciler Signed-off-by: K... aba1a78
KevFan closed a pull request on Kuadrant/kuadrant-operator
refactor: effective tls policies reconciler
# Description Part of https://github.com/Kuadrant/kuadrant-operator/issues/819 https://github.com/Kuadrant/kuadrant-operator/issues/824 * Refactor the logic for the management of TLSPolicy Cert...
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
You are right. That would be simpler. No need to iterate over the gateway classes (as this would be abstracted inside of calculating the topological paths to the http route rules).
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
This is a very good question I asked myself a few times. In the end I decided not to do that for 2 reasons: 1. DRY – the decision of which gateways we build effective RateLimitPolicies for belongs...
Boomatang created a review on a pull request on Kuadrant/kuadrant-operator
I am happy to approve this. Any comment I had was based around styling which can be done later.
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
It's left as a comment. This is how we'd implement the status check on the EnvoyFilter CR if Istio ever cares to update the subresources.
Boomatang created a review comment on a pull request on Kuadrant/kuadrant-operator
I am happy with leaving this for now. It is some thing that can be done in the future.
Boomatang created a review comment on a pull request on Kuadrant/kuadrant-operator
I have a funny feeling about this. It seems like we should have know that we are meant to delete object before we ever got this far. To me once we created the the `wasmConfig` we should know that a...
Boomatang created a review comment on a pull request on Kuadrant/kuadrant-operator
I am wondering if we restructure the code to have the delete steps before the create can this logic block be removed?
Boomatang created a review on a pull request on Kuadrant/kuadrant-operator
Any of the points I am making are for future conversations and are not expected to be address here. All worked as expected. You might want get approval from more that me.
Boomatang created a review on a pull request on Kuadrant/kuadrant-operator
Any of the points I am making are for future conversations and are not expected to be address here. All worked as expected. You might want get approval from more that me.
guicassolato created a comment on a pull request on Kuadrant/kuadrant-operator
> The guides have not being updated to use v1betat3. I expect this to happen with or shortly after the adding of the Section Name. Maybe I'm being naive here, but with this PR (unlike #875), we ...
KevFan created a review comment on a pull request on Kuadrant/kuadrant-operator
Updated to filter for tls policies. I'm aware of the multiple reconciles for gateway policies but I think I'll look to address this as I look into the reconcile for section name support in another PR.