Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
KevFan created a review comment on a pull request on Kuadrant/kuadrant-operator
Thanks guys 👍 I don't think it matters in fairness unless people really feel it hinders readability. My preference is to keep it as is tbh as I also prefer dealing with the `create` first followed...
KevFan created a review comment on a pull request on Kuadrant/kuadrant-operator
Yes, that's true, this should check for policies of specific type before failing back also 👍 Yes, unfortunately, this would reconcile a gateway policy multiple times. Not quite sure how to approa...
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
`if ok { update }` / `if !ok { create }`. Does it matter? The number of jump instructions in the final compiled code is literally the same I think. If `!ok` feels like being negative (it doesn't...
KevFan created a review comment on a pull request on Kuadrant/kuadrant-operator
Oh yes, good catch 👍 This might be why integrations tests are failing now 😅
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
Is it good enough to just assume if you no policies use the gateway ones? Should it not check for a policy of the expected type being attached to the listener and if none fallback? Will this not al...
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
I wouldn't expect too many updates of a Certificate resource after creation. I don't have strong opinions on this, but for what its worth i did `if ok` in the dnspolicy equivalent task, and deal wi...
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
@mikenairn is right. `.Policies()` will return policies of all kinds.
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
I may have misunderstood this before. I thought the multiple test suites were running in parallel to each other, what would cause multiple deployments of the Kuadrant Operator running concurrently ...
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
Could policy here be a different type? Is the policies list filtered by type anywhere?
mikenairn created a review comment on a pull request on Kuadrant/kuadrant-operator
Not sure this will work if you have more than one different policy on the listener (DNSPolicy and TLSPolicy)
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
Nice work, @KevFan. This will easily adapt to when we decide to support `sectionName` and effectively inheritance on TLSPolicies.
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
Indeed we need to cleanup certs that remained orphan due to, e.g., a listener being removed from a gateway _ceteris paribus_. Let's keep this as-is now since it does the job. Maybe in the future...
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
This is not the right solution. Actually what we want is to no longer create one Kuadrant CR per test suite, but one single instance per cluster only, and write tests with that in mind.
guicassolato pushed 2 commits to sotw/rlp Kuadrant/kuadrant-operator
- refactor: common.NamespacedNameFromLocator func Signed-off-by: Guilherme Cassolato <[email protected]> bee0baf
- hack to isolate test namespaces sharing the same limitador cr Signed-off-by: Guilherme Cassolato <guicassolato@gmail... d5af8ca