Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
KevFan created a review comment on a pull request on Kuadrant/kuadrant-operator
I've reverted it since it looks to give more concerns that needed. Let's have a look can this be optimized in another PR or later point
Boomatang created a review comment on a pull request on Kuadrant/kuadrant-operator
Ya sure, it is outside the doc guides and would be missed.
Boomatang created a review comment on a pull request on Kuadrant/kuadrant-operator
Correct, when you break form your normal workflow things like this happen. I blame `git add . ` for that.
Boomatang created a review comment on a pull request on Kuadrant/kuadrant-operator
I am not sure how I feel about looping over the events like this. However, would it not make more sense to use a switch statement over this individual if blocks,
KevFan created a review comment on a pull request on Kuadrant/kuadrant-operator
Let's rename https://github.com/Kuadrant/kuadrant-operator/blob/1ac1104edae00a64cc3eae224f07fee46aadc190/config/samples/kuadrant_v1beta2_authpolicy.yaml to `kuadrant_v1beta3_authpolicy.yaml ` and a...
KevFan created a review comment on a pull request on Kuadrant/kuadrant-operator
I'm assuming this file is not meant to be in this PR?
KevFan created a review on a pull request on Kuadrant/kuadrant-operator
Looks good overall 👍 Left 2 comments 🧑💻
KevFan created a review on a pull request on Kuadrant/kuadrant-operator
Looks good overall 👍 Left 2 comments 🧑💻
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- tests: fix integration tests - Istio WasmPlugin config with correct limit IDs and scopes Signed-off-by: Guilherme Ca... f7f57ac
guicassolato pushed 2 commits to sotw/rlp Kuadrant/kuadrant-operator
- tests: fix integration tests - Istio EnvoyFilter only created if RLP is in the path to a route Signed-off-by: Guilhe... 043f265
- lint: removed unnused func arg in the tests Signed-off-by: Guilherme Cassolato <[email protected]> 3f6871b
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- policy not enforced due to 'not in the path to any existing routes' (formerly reported as 'no free routes to enforce ... 452052e
KevFan created a comment on an issue on Kuadrant/kuadrant-operator
TLSPolicy was done as part of https://github.com/Kuadrant/kuadrant-operator/pull/885 for if CertManager CRDs are not detected. This has not been done for any other Policies though
eguzki created a comment on an issue on Kuadrant/kuadrant-operator
If the cert manager CRDs are not in place, TLS policies status report on that issue?
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
I would not say we should avoid filtering policies. Rather, I would say we should avoid writing new logic for things otherwise represented in the topology. I believe what we want here is get to ...
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
True. I was thinking on getting the gateway from the topology. Indeed `g := machinery.Gateway{Gateway: ob.(*gwapiv1.Gateway)}` is no good.
guicassolato pushed 52 commits to sotw/rlp Kuadrant/kuadrant-operator
- Disable Authorino webhooks service (#945) Signed-off-by: Guilherme Cassolato <[email protected]> 011bd8b
- sotw: effective ratelimitpolicy - ratelimit workflow - ratelimitopolicies validator - effective ratelimitpolicies re... 7f55e38
- removed unused function to apply rlp overrides Signed-off-by: Guilherme Cassolato <[email protected]> 5f994fd
- istio extension (WasmPlugin) reconciler Signed-off-by: Guilherme Cassolato <[email protected]> 8e6122d
- fixup: unique limit definitions per scope Signed-off-by: Guilherme Cassolato <[email protected]> c2a016a
- fixup: log error only when indeed there's an error to be logged Signed-off-by: Guilherme Cassolato <guicassolato@gma... f42b60a
- do not fail when missing kuadrant object Signed-off-by: Guilherme Cassolato <[email protected]> 52cf271
- fixup: equality between wasmplugins and avoid rebuilding wasm config from struct when nil Signed-off-by: Guilherme C... 7e4ff84
- fixup: error comparison Signed-off-by: Guilherme Cassolato <[email protected]> 7069136
- cleanup istio extension objects when it cannot calculate effective policies Signed-off-by: Guilherme Cassolato <guic... b3b9b69
- refactor: removal of SortablePolicy for sorting policies objects by creation timestamp Signed-off-by: Guilherme Cass... 6d7b7c9
- remove no longer relevant integration test case Signed-off-by: Guilherme Cassolato <[email protected]> b0a9ff7
- fixup: avoid updating invalid rate limit policies to 'accepted' on events that do not (re)validate policies Signed-o... 821b4fc
- fixup: continue istio extension workflow when it fails for a given gateway Signed-off-by: Guilherme Cassolato <guica... b8063f1
- Remove unnused event recorder from base reconciler Signed-off-by: Guilherme Cassolato <[email protected]> de31145
- Istio rate limit cluster reconciler Signed-off-by: Guilherme Cassolato <[email protected]> 5117dcb
- enable Istio-related rate limit tasks only when Istio is installed Signed-off-by: Guilherme Cassolato <guicassolato@... c3bdc77
- ensure at least one hostname per wasm config policy Signed-off-by: Guilherme Cassolato <[email protected]> 60ec968
- bump istio to 1.22 Signed-off-by: Guilherme Cassolato <[email protected]> 0ae1ab4
- Use targetRefs to attach to gateways in the Istio EnvoyFilter and WasmPlugin resources Signed-off-by: Guilherme Cass... 0aa97fc
- and 32 more ...
guicassolato pushed 1 commit to main Kuadrant/kuadrant-operator
- Disable Authorino webhooks service (#945) Signed-off-by: Guilherme Cassolato <[email protected]> 011bd8b
guicassolato closed an issue on Kuadrant/kuadrant-operator
Auth controller to DAG 1.0
Ensure Auth controller uses that DAG as expaected
guicassolato opened an issue on Kuadrant/kuadrant-operator
[state-of-the-world reconciler] Error handling for final API server errors
Handle API server errors that does not allow assuming presence of new events pending to be processed in the. E.g. `429 Too many requests`. These kinds of errors may require re-triggering the rec...