Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
KevFan created a review comment on a pull request on Kuadrant/kuadrant-operator
Hmm, I didn't intend to do this, but that is simpler indeed. Why it's working as is due to there's no work to be done on tlspolicies marked for deletion 🤔
KevFan created a review comment on a pull request on Kuadrant/kuadrant-operator
Hmm, dont think i'm able to since `g` is a new `machinery.Gateway` instance, so the `policies` will be `nil` unless you're saying to get the `machinery.Gateway` instance elsewhere? 🤔
Boomatang created a review comment on a pull request on Kuadrant/kuadrant-operator
I think this needs address as it brings in results that are not created by kuadrant and kuadrant has no right to know about.
Boomatang created a review comment on a pull request on Kuadrant/kuadrant-operator
I question if this function is needed
Boomatang created a review comment on a pull request on Kuadrant/kuadrant-operator
Is this filtering being done wrongly, only records that are created by a DNSPolicy should ever end up in the topology. With how the linking function is set up an orphaned record would become a root...
Boomatang created a review comment on a pull request on Kuadrant/kuadrant-operator
After looking at the implementation for `getObjectPolicyOwnerReference`, I am wondering if the function is need at all.
Boomatang created a review on a pull request on Kuadrant/kuadrant-operator
Sorry for not posting all comments as one review. I pressed the wrong button to many times. I have a concern that there are DNSRecords being added to the topology that should not be there. This ...
Boomatang created a review on a pull request on Kuadrant/kuadrant-operator
Sorry for not posting all comments as one review. I pressed the wrong button to many times. I have a concern that there are DNSRecords being added to the topology that should not be there. This ...
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- helper function to extract network objects in a request path Signed-off-by: Guilherme Cassolato <guicassolato@gmail.... e0bedf4
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- helper function to extract network objects in a request path Signed-off-by: Guilherme Cassolato <guicassolato@gmail.... 0f95c22
Boomatang created a review comment on a pull request on Kuadrant/kuadrant-operator
Why would there be DNSRecords in the topology that are not linked to a DNSPoicy if they are just going to be ignored. There may need to be improvements done to the DNSRecords watchable filters.
Boomatang created a review comment on a pull request on Kuadrant/kuadrant-operator
Why is there DNSRecords in the topology that were not created by a DNSPolicy. There many need to be improvements done to the DNSRecords watchable filters.
Boomatang created a review comment on a pull request on Kuadrant/kuadrant-operator
Is there plans to put a precondition or post-condition in the Workflow defined here. If there is no plan does it not make more sense to add the reconcile directly to the outer tasks list.
guicassolato pushed 4 commits to sotw/rlp Kuadrant/kuadrant-operator
- back to opaque wasm action set names Signed-off-by: Guilherme Cassolato <[email protected]> ecdc5bc
- remove duplicate GetKuadrantFromTopology func Signed-off-by: Guilherme Cassolato <[email protected]> 62bd690
- do not isolate policy-machinery imports in a separate group Signed-off-by: Guilherme Cassolato <[email protected]> 3646807
- helper function to extract network objects in a request path Signed-off-by: Guilherme Cassolato <guicassolato@gmail.... 07e9f48
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- tests: fix integration tests - order of wasm action sets (again!) Signed-off-by: Guilherme Cassolato <guicassolato@g... 0b76b6c
adam-cattermole created a comment on a pull request on Kuadrant/kuadrant-operator
I have tested on top of RLP from #893 and can see things working as expected.
adam-cattermole opened a draft pull request on Kuadrant/kuadrant-operator
Install sail-operator 0.1.0
Installs sail-operator using helm from [istio-ecosystem/[email protected]](https://github.com/istio-ecosystem/sail-operator/releases/tag/0.1.0) and re-enables integration tests. This is depend...
adam-cattermole created a branch on Kuadrant/kuadrant-operator
install-sail-tp - The Operator to install and manage the lifecycle of the Kuadrant components deployments.
adam-cattermole created a comment on a pull request on Kuadrant/kuadrant-operator
As most of the changes here are no longer relevant I'm going to close this and open a new pulling in only the changes to install the sail-operator release and I'll test it on top of the ongoing cha...
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- fixup: should not increment twice on the index of http route match when building the wasm action set name Signed-off... 3040027
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- more descriptive wasm actionset names Signed-off-by: Guilherme Cassolato <[email protected]> b870328
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- more descriptive wasm actionset names Signed-off-by: Guilherme Cassolato <[email protected]> 1d18a33
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- more descriptive wasm actionset names Signed-off-by: Guilherme Cassolato <[email protected]> e7a757e
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- more descriptive wasm actionset names Signed-off-by: Guilherme Cassolato <[email protected]> d72cfd6
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- more descriptive wasm actionset names Signed-off-by: Guilherme Cassolato <[email protected]> 4042873