Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
I'm actually surprised equality (`==`) between two policy works.
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- tests: gateway extension reconciler tests resource comparison Signed-off-by: Guilherme Cassolato <guicassolato@gmail... 5f1109a
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
Hmm. Maybe specify a uniqueness key and thus avoid possible problems with pointer comparison: ```suggestion return lo.UniqBy(affectedPolicies, func(p machinery.Policy) string { return p.GetLoc...
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
I believe you could leverage the topology links here too: ```suggestion c, _ := ob.(*controller.RuntimeObject).Object.(*certmanagerv1.Certificate) listeners := topology.Targetables().Par...
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
I understand this will filter out all TLSPolicies that have been deleted. Unless that's what indeed you want, could we simply cast `ob` maybe? ```suggestion p, _ := ob.(*TLSPolicy) affec...
guicassolato created a review comment on a pull request on Kuadrant/kuadrant-operator
Have you considered using [`g.Policies()`](https://github.com/Kuadrant/policy-machinery/blob/72b15c675f8d03489ae926288b3fd2d426174fe6/machinery/types.go#L39C2-L39C12)?
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- tests: gateway extension reconciler tests resource comparison Signed-off-by: Guilherme Cassolato <guicassolato@gmail... 0a6e7f4
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- tests: gateway extension reconciler tests resource comparison Signed-off-by: Guilherme Cassolato <guicassolato@gmail... 80bd0ae
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- tests: create gatewayclass Signed-off-by: Guilherme Cassolato <[email protected]> c1ee35b
guicassolato pushed 18 commits to sotw/rlp Kuadrant/kuadrant-operator
- sort wasm 'policies' within the wasm plugin config by hostname and http route match from most specific to least speci... c84b653
- code style: remove unused parameter ctx Signed-off-by: Guilherme Cassolato <[email protected]> f1a9669
- fix: unit test: sort wasm 'policies' within the wasm plugin config by hostname and http route match Signed-off-by: G... d052f9e
- Refactor WasmPlugin reconciliation to reduce repetition with EnvoyExtensionPolicy and ease the merge of auth * Separ... cf44f68
- envoy gateway rate limit cluster reconciler Signed-off-by: Guilherme Cassolato <[email protected]> 3735abc
- fix: wrong default GroupKind assumed on Istio policies TargetRefs Signed-off-by: Guilherme Cassolato <guicassolato@g... 664634a
- minor fixes to code comments and log messages Signed-off-by: Guilherme Cassolato <[email protected]> a23579d
- envoy gateway extension reconciler Signed-off-by: Guilherme Cassolato <[email protected]> c21b494
- code style: ratelimit.RateLimitIndex -> Index Signed-off-by: Guilherme Cassolato <[email protected]> a3e4b5d
- code style: wasm.WasmExtensionName -> ExtensionName Signed-off-by: Guilherme Cassolato <[email protected]> 6ab3ec8
- code style: wasm.WasmRuleBuilderFunc -> RuleBuilderFunc Signed-off-by: Guilherme Cassolato <[email protected]> 1e9829e
- code style: fix grouping of go imports Signed-off-by: Guilherme Cassolato <[email protected]> 9d7bcd1
- new structure of the wasm config based on https://github.com/Kuadrant/wasm-shim/pull/110 Signed-off-by: Guilherme Ca... e3d5387
- fix: envoy_gateway_extension_reconciler.go file name Signed-off-by: Guilherme Cassolato <[email protected]> f7b6a29
- fix: log messages of envoy patch policy reconciliation Signed-off-by: Guilherme Cassolato <[email protected]> be54de3
- rlp enforced condition and consistency in the message when target not found Signed-off-by: Guilherme Cassolato <guic... 5c6ccbc
- fix integration tests Signed-off-by: Guilherme Cassolato <[email protected]> 3aadd90
- tests: create gatewayclass Signed-off-by: Guilherme Cassolato <[email protected]> 011ce7f
guicassolato pushed 51 commits to sotw/rlp Kuadrant/kuadrant-operator
- helm: keep namespace in manager.yaml and remove from helm overlay (#934) Signed-off-by: Eguzki Astiz Lezaun <eastizl... 2ece035
- Sotw add limitador reconcile (#887) * ADD: Limitador sotw reconcile This sets up the subscription for events on k... c0438c3
- Consoleplugin mutator (#935) * consoleplugin mutator Signed-off-by: Eguzki Astiz Lezaun <[email protected]> ... cd7f9c2
- Update: Improve get kuadrant resource (#910) * Update: Improve get kuadrant resource Updates the getting of the k... 60d5d43
- Rename kuadrant-console to kuadrant-console-plugin (#940) Signed-off-by: Jason Madigan <[email protected]> 0f1c583
- small updates and improvements for install docs (#939) Signed-off-by: craig <[email protected]> rh-pre-commit.v... 9dac15e
- REMOVE: kuadrant controller management of limitador (#888) * REMOVE: kuadrant controller management of limitador ... 45efe5d
- extend health check spec (#936) Signed-off-by: Maskym Vavilov <[email protected]> ab08b3e
- tests: Add test suite common resource labels and fix dnsrecord cleanup (#941) * tests: Add common label to all test ... 76ca68f
- tests: Add additional dnspolicy integration tests (#942) Adds/Updates tests to better cover dnsrecord deletion scena... 5d76689
- ci: Add kuadrant status check step to test jobs (#943) Adds a step to the integration test jobs to display the pods ... d4e205f
- sotw: effective ratelimitpolicy - ratelimit workflow - ratelimitopolicies validator - effective ratelimitpolicies re... c62946d
- removed unused function to apply rlp overrides Signed-off-by: Guilherme Cassolato <[email protected]> 0241d73
- istio extension (WasmPlugin) reconciler Signed-off-by: Guilherme Cassolato <[email protected]> 556cbf1
- fixup: unique limit definitions per scope Signed-off-by: Guilherme Cassolato <[email protected]> e95e8eb
- fixup: log error only when indeed there's an error to be logged Signed-off-by: Guilherme Cassolato <guicassolato@gma... b49a6e2
- do not fail when missing kuadrant object Signed-off-by: Guilherme Cassolato <[email protected]> d625294
- fixup: equality between wasmplugins and avoid rebuilding wasm config from struct when nil Signed-off-by: Guilherme C... ed863c6
- fixup: error comparison Signed-off-by: Guilherme Cassolato <[email protected]> 1eda5ed
- cleanup istio extension objects when it cannot calculate effective policies Signed-off-by: Guilherme Cassolato <guic... 923a0db
- and 31 more ...
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- tests: create gatewayclass Signed-off-by: Guilherme Cassolato <[email protected]> 75d385b
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- fix integration tests Signed-off-by: Guilherme Cassolato <[email protected]> a446520
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- fix integration tests Signed-off-by: Guilherme Cassolato <[email protected]> db86a46
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- fix integration tests Signed-off-by: Guilherme Cassolato <[email protected]> 341c4b9
guicassolato created a comment on a pull request on Kuadrant/kuadrant-operator
Still pending here: - [ ] Status `Enforced` condition - what policy has dropped a limit from an effective policy (by atomic override) - [ ] RateLimitPolicy discoverability (aka `PolicyAffected` s...
guicassolato pushed 1 commit to sotw/rlp Kuadrant/kuadrant-operator
- rlp enforced condition and consistency in the message when target not found Signed-off-by: Guilherme Cassolato <guic... 9a4d7b4
guicassolato pushed 3 commits to sotw/rlp Kuadrant/kuadrant-operator
- fix: envoy_gateway_extension_reconciler.go file name Signed-off-by: Guilherme Cassolato <[email protected]> 9c7c180
- fix: log messages of envoy patch policy reconciliation Signed-off-by: Guilherme Cassolato <[email protected]> cc1d4d8
- rlp enforced condition and consistency in the message when target not found Signed-off-by: Guilherme Cassolato <guic... e24d94f
mikenairn deleted a branch Kuadrant/kuadrant-operator
ci_add_kuadrant_status_check_step_to_test_jobs
mikenairn pushed 1 commit to main Kuadrant/kuadrant-operator
- ci: Add kuadrant status check step to test jobs (#943) Adds a step to the integration test jobs to display the pods ... d4e205f
mikenairn closed a pull request on Kuadrant/kuadrant-operator
ci: Add kuadrant status check step to test jobs
Adds a step to the integration test jobs to display the pods in the kuadrant-system namespace. More info could be added here, but for now this is enough to tell you if the pods were restarting duri...KevFan created a review on a pull request on Kuadrant/kuadrant-operator
Looks good to me
mikenairn pushed 1 commit to main Kuadrant/kuadrant-operator
- tests: Add additional dnspolicy integration tests (#942) Adds/Updates tests to better cover dnsrecord deletion scena... 5d76689