Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Avoid dynamically altering the 'from' email address** Appending a timestamp to the 'from' email address changes the sender email for each notification. This can lead...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:hammer_and_wrench: Refactor suggestion_ **Simplify email validation by reusing existing method** In the `getFromEmail()` method, you're using `filter_var` directly for email validation. Since y...
coderabbitai[bot] created a review on a pull request on JhumanJ/OpnForm
**Actionable comments posted: 2** <details> <summary>🧹 Outside diff range and nitpick comments (9)</summary><blockquote> <details> <summary>api/app/Integrations/Handlers/EmailIntegration.php (1)<...
coderabbitai[bot] created a comment on a pull request on JhumanJ/OpnForm
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> > [!NOTE] > Currently processing new changes ...
duplaja opened a pull request on JhumanJ/OpnForm
Adds Custom From E-Mail Option to Confirmation and Notification Integrations
This adds a field to each confirmation and notification integration, allowing the setting of a custom "from" email address, as long as the provider supports it. For now, the custom from email on...
SindreKjelsrud opened an issue on JhumanJ/OpnForm
[BUG] Profile menu covered by breadcrumbs-bar inside template
**Describe the bug** When entering a template and wanting to check `My Forms` in the dropdown menu for your profile, the breadcrumbs-bar covers part of the menu. Hinders the user in accessing thei...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Check for undefined `integrationData.settings` before accessing its properties** In the `onBeforeMount` hook, `props.integrationData.settings[keyname]` is accessed w...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Safely access `integrationData.settings.include_submission_data` in `v-if` directive** In the `v-if` directive on line 53, accessing `integrationData.settings.includ...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:hammer_and_wrench: Refactor suggestion_ **Remove unused prop `formIntegrationId`** The prop `formIntegrationId` is defined but not used in the component. If it's not required, consider removing...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Avoid variable shadowing by renaming the 'form' parameter** The `submitForm` method accepts a parameter named `form`, which may cause confusion with the `this.form` ...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Potential XSS vulnerability due to unsanitized `innerHTML` usage** Assigning content to `innerHTML` without proper sanitization can lead to Cross-Site Scripting (XSS...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Validate user input when setting attributes** When setting attributes with user-provided data in `createMentionSpan`, ensure that the input is properly validated or ...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:hammer_and_wrench: Refactor suggestion_ **Consider deep merging for quillOptions modules** When merging `defaultOptions` with `props.editorOptions`, the current spread operator `{ ...defaultOpt...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Handle missing `subject` in `integrationData`** Accessing `$this->integrationData->subject` without checking if it exists may cause an error if `subject` is not set....
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Handle missing `email_content` in `integrationData`** Similarly, accessing `$this->integrationData->email_content` without a check may result in an error if `email_c...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Reconsider dynamic 'from' email address generation** In the `getFromEmail()` method, generating a dynamic 'from' email address using `time()` may lead to email deliv...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Type-hint the `$mailer` property** Based on previous learnings, the `$mailer` property should be typed as `string` to ensure type safety and consistency. Apply th...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Import `nextTick` from `'vue'`** The `nextTick` function is used at line 117 but not imported, which will cause a `ReferenceError` at runtime. Please import `nextTic...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:hammer_and_wrench: Refactor suggestion_ **Replace `super.create()` with `Inline.create()` in static method** Using `super`` in a static context can be confusing, as indicated by the static anal...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Simplify mention length calculation** Since the `MentionBlot` has a fixed length of `1` (as defined in the `length()` method), you can simplify the calculation by se...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Add missing imports for 'computed' and 'watch' from 'vue'** The `computed` and `watch` functions are used but not imported from `'vue'`. This will lead to `Reference...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Import or define 'defineShortcuts'** The function `defineShortcuts` is used to handle keyboard shortcuts but is neither imported nor defined within this component. T...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:bulb: Codebase verification_ **Inconsistent Usage of `$integration->data` Detected** The analysis reveals that `$integration->data` is treated both as an object and as an array in different p...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Ensure `getMentionHtml` returns a valid recipient** If `getMentionHtml` returns an empty string because no email field is found, the `send_to` field in `$integration...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Handle cases where `$form->properties` is null or not iterable** There might be scenarios where `$form->properties` is `null` or not an array/object, which would cau...
coderabbitai[bot] created a review comment on a pull request on JhumanJ/OpnForm
_:warning: Potential issue_ **Add a null check for `$form` to prevent errors** In the `getRespondentEmail` method, if the form with the given `$formId` does not exist, `$form` will be `null`. Att...