Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Jericho pushed 3 commits to develop Jericho/ZoomNet
Jericho pushed 1 commit to develop Jericho/ZoomNet
- Add external contacts endpoints (#385) * Add external contacts endpoints * Remove extra string interpolation operat... 8def4c0
Jericho closed a pull request on Jericho/ZoomNet
Add external contacts endpoints
In our project we want to add all our customers as excternal contacts. So we are interested in adding endpoints to handle Zoom Phone external contacts. I've added separate resource for this grou...
Jericho created a review on a pull request on Jericho/ZoomNet
Looks good! Thank you for your contribution.
ivan-pavlik created a review comment on a pull request on Jericho/ZoomNet
Fixed (Pavel is on vacation, he granted me permissions to his fork, so I'm applying comments on his behalf).
Jericho created a review comment on a pull request on Jericho/ZoomNet
Similar to my previous comment, I would rename this method to `UpdateAsync`.
Jericho created a review comment on a pull request on Jericho/ZoomNet
Similar to my previous comment, I would rename this method to `DeleteAsync`.
Jericho created a review comment on a pull request on Jericho/ZoomNet
Good call reusing an existing model class rather that creating yet another one!
Jericho created a review comment on a pull request on Jericho/ZoomNet
When a resource is retrieving all records, the naming convention in ZoomNet is to call the method `GetAllAsync`. For example: - https://github.com/Jericho/ZoomNet/blob/develop/Source/ZoomNet/Re...
Jericho created a review comment on a pull request on Jericho/ZoomNet
As I mentioned in my previous comment, I would avoid "ExternalContacts" in the name of this method. I think `AddAsync` is sufficient.
Jericho created a review comment on a pull request on Jericho/ZoomNet
I have tried as much as possible to avoid repeating the name of the resource in the name of methods because I find it repetitive and verbose. Therefore I would prefer if you renamed this method sim...
Jericho created a review on a pull request on Jericho/ZoomNet
Looks very good. Looking forward to merging your PR.
Jericho created a review on a pull request on Jericho/ZoomNet
Looks very good. Looking forward to merging your PR.
Jericho pushed 1 commit to develop Jericho/ZoomNet
- Upgrade the Formitable.BetterStack.Logger packages to 0.1.3-beta0001 (which I created) while I wait for the bug I rep... df3987b
Jericho created a branch on Jericho/ZoomNet
feature/external-contacts - .NET client library for the Zoom.us REST API v2
Jericho pushed 1 commit to develop Jericho/ZoomNet
- Add one more unit test for ParticipantDevice parsing 67757a3
Jericho created a comment on a pull request on Jericho/ZoomNet
Thanks for submitting this PR. I didn't have time to review today but I'll have a look over the weekend.
pvgritsenko-ansible opened a pull request on Jericho/ZoomNet
Add external contacts endpoints
In our project we want to add all our customers as excternal contacts. So we are interested in adding endpoints to handle Zoom Phone external contacts. I've added separate resource for this grou...
Jericho created a comment on an issue on Jericho/ZoomNet
I am surprised to hear this because the problem was addressed in #370 with [this commit](https://github.com/Jericho/ZoomNet/commit/b5a84fd2f03fcf2c45976fe7374c53896ccbf13f). This fix was released i...