Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
evenyag created a review comment on a pull request on GreptimeTeam/greptimedb
This use the debug format. Is it expected? Maybe we should use display. ```suggestion METRIC_META_HEARTBEAT_RECV.with_label_values(&[&k.to_string()]); ```
evenyag closed an issue on GreptimeTeam/greptimedb
Workflow run 'GreptimeDB Nightly Build' failed
@GreptimeTeam/db-approver New failure: https://github.com/GreptimeTeam/greptimedb/actions/runs/11476544372
evenyag created a review comment on a pull request on GreptimeTeam/greptimedb
Maybe we should set it as field if it is float as a float tag is usually meaningless.
waynexia created a comment on a pull request on GreptimeTeam/greptimedb
> adjust flow's column check so that update_at column is only appended when possible Do you think it's necessary to describe the "when possible" in document? To my understanding this PR is actua...
waynexia created a review comment on a pull request on GreptimeTeam/greptimedb
```suggestion -- auto generated column by flow engine update_at TIMESTAMP, ```
github-actions[bot] opened an issue on GreptimeTeam/greptimedb
Workflow run 'GreptimeDB Nightly Build' failed
@GreptimeTeam/db-approver New failure: https://github.com/GreptimeTeam/greptimedb/actions/runs/11476544372
evenyag created a review comment on a pull request on GreptimeTeam/greptimedb
Do we need to return `duration(0)` to indicate this?
evenyag created a review comment on a pull request on GreptimeTeam/greptimedb
Can we rename to `change_table_options`? We didn't mention attrs. ```suggestion fn change_table_options( &self, requests: &[ChangeTableOptionRequest], ) -> Result<Table...
evenyag created a review comment on a pull request on GreptimeTeam/greptimedb
This is region level. ```suggestion /// Change region options. ChangeRegionOptions { options: Vec<ChangeRegionOption> }, ```
evenyag created a review comment on a pull request on GreptimeTeam/greptimedb
Can we use https://docs.rs/sqlparser/latest/sqlparser/parser/struct.Parser.html#method.parse_options_with_keywords This is how sql parser parses this statement. https://docs.rs/sqlparser/latest...
evenyag created a review comment on a pull request on GreptimeTeam/greptimedb
We don't need to persist this as we already store table options in meta server and we only need to update the in memory state of the region.
Kev1n8 created a comment on an issue on GreptimeTeam/greptimedb
As discussed at [here](https://github.com/GreptimeTeam/greptimedb/pull/4864#discussion_r1812018609), we will keep the param non-nullable but return null when json is `parse_json('null')`.
evenyag created a review comment on a pull request on GreptimeTeam/greptimedb
```suggestion tokio::task::yield_now().await; ```
evenyag created a review comment on a pull request on GreptimeTeam/greptimedb
```suggestion /// Rate limiter of this future ```
evenyag created a review comment on a pull request on GreptimeTeam/greptimedb
```suggestion - Introduce PID to achieve more accurate limitation. ```
github-actions[bot] pushed 1 commit to gh-pages GreptimeTeam/greptimedb
- Deploying to gh-pages from @ GreptimeTeam/greptimedb@5d42e63ab054eb94dfe129ac1171e382e2acf800 🚀 6334b85
evenyag closed a pull request on GreptimeTeam/greptimedb
fix!: replace timeout_millis and connect_timeout_millis with Duration in DatanodeClientOptions
I hereby agree to the terms of the [GreptimeDB CLA](https://github.com/GreptimeTeam/.github/blob/main/CLA.md). ## Refer to a related PR or issue link (optional) ## What's changed and what's y...
github-merge-queue[bot] deleted a branch GreptimeTeam/greptimedb
gh-readonly-queue/main/pr-4867-0c01532a37d5deb4820d88d0e5edee48749e2a06
github-merge-queue[bot] pushed 1 commit to main GreptimeTeam/greptimedb
- fix!: replace timeout_millis and connect_timeout_millis with Duration in DatanodeClientOptions (#4867) * fix: correc... 5d42e63
github-merge-queue[bot] created a branch on GreptimeTeam/greptimedb
gh-readonly-queue/main/pr-4867-0c01532a37d5deb4820d88d0e5edee48749e2a06 - An open-source, cloud-native, unified time series database for metrics, logs and events with SQL/PromQL supported. Available on GreptimeCloud.