Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
katie-gardner created a review on a pull request on DFE-Digital/sts-plan-technology-for-your-school
sonarcloud[bot] created a comment on a pull request on DFE-Digital/sts-plan-technology-for-your-school
## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=...
katie-gardner pushed 1 commit to feat/230609/generic-add-question-preview DFE-Digital/sts-plan-technology-for-your-school
- chore: simplify fetching from contentful 2afa3d1
katie-gardner pushed 1 commit to feat/230609/generic-add-question-preview DFE-Digital/sts-plan-technology-for-your-school
- chore: Remove unnecessary section fetching 2ff154d
jimwashbrook deleted a branch DFE-Digital/sts-plan-technology-for-your-school
fix/230442/back-button
jimwashbrook closed a pull request on DFE-Digital/sts-plan-technology-for-your-school
fix: Amend default back button behaviour + text for non-JS users
## Overview Amends the back button link to show "Home", and redirect to the self-assessment page, for non-JS users. ## Changes ### Minor - Duplicates back button links; one for non-JS, one for ...jack-coggin created a review on a pull request on DFE-Digital/sts-plan-technology-for-your-school
katie-gardner created a review comment on a pull request on DFE-Digital/sts-plan-technology-for-your-school
I just read your other comment, I reckon, I can skip the form if section is not passed in and thereby make submitting impossible
katie-gardner created a review on a pull request on DFE-Digital/sts-plan-technology-for-your-school
katie-gardner created a review comment on a pull request on DFE-Digital/sts-plan-technology-for-your-school
We don't, the section stuff is purely for the form, because submit answer needs it, and the preview reuses the question page - I was considering making a `QuestionPreview.cshtml` page that removes ...
katie-gardner created a review on a pull request on DFE-Digital/sts-plan-technology-for-your-school
jimwashbrook created a review comment on a pull request on DFE-Digital/sts-plan-technology-for-your-school
Other thought: If we _need_ the section then you can _probably_ just do a Contentful query to 1. Retrieve the section, where it has a matching question 2. Filter out what we return from the AP...
jimwashbrook created a review on a pull request on DFE-Digital/sts-plan-technology-for-your-school
sonarcloud[bot] created a comment on a pull request on DFE-Digital/sts-plan-technology-for-your-school
## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=...
katie-gardner created a review on a pull request on DFE-Digital/sts-plan-technology-for-your-school
jimwashbrook pushed 1 commit to fix/230442/back-button DFE-Digital/sts-plan-technology-for-your-school
- fix: Amend default back button behaviour + text for non-JS users fix: id tests: Add back button link E2E test fix:... d91aa6d
jimwashbrook opened a pull request on DFE-Digital/sts-plan-technology-for-your-school
fix: Amend default back button behaviour + text for non-JS users
## Overview Amends the back button link to show "Home", and redirect to the self-assessment page, for non-JS users. ## Changes ### Minor - Duplicates back button links; one for non-JS, one for ...jimwashbrook pushed 1 commit to fix/230442/back-button DFE-Digital/sts-plan-technology-for-your-school
- fix: Amend default back button behaviour + text for non-JS users fix: id tests: Add back button link E2E test 7132b8a
jimwashbrook created a branch on DFE-Digital/sts-plan-technology-for-your-school
fix/230442/back-button - Web application to help schools plan a technology roadmap
jimwashbrook created a review on a pull request on DFE-Digital/sts-plan-technology-for-your-school
Looks good to me, but haven't tested it yet. Will do so shortly. Few comments otherwise. My only other thought is; IMO we should render a specific question preview page, or something similar. Ba...
jimwashbrook created a review comment on a pull request on DFE-Digital/sts-plan-technology-for-your-school
If we're just rendering the question page, what do we need all the section details for?
jimwashbrook created a review on a pull request on DFE-Digital/sts-plan-technology-for-your-school
jimwashbrook created a review comment on a pull request on DFE-Digital/sts-plan-technology-for-your-school
Would be good to move all this logic out somewhere else IMO but YMMV
jimwashbrook created a review on a pull request on DFE-Digital/sts-plan-technology-for-your-school
jimwashbrook created a review comment on a pull request on DFE-Digital/sts-plan-technology-for-your-school
Why not use `GetEntityById`?
jimwashbrook created a review on a pull request on DFE-Digital/sts-plan-technology-for-your-school
github-actions[bot] pushed 1 commit to feat/216478/create-webhooks-programatically DFE-Digital/sts-plan-technology-for-your-school
- terraform-docs: automated action d36f189
jimwashbrook pushed 37 commits to feat/216478/create-webhooks-programatically DFE-Digital/sts-plan-technology-for-your-school
- chore: added C&S repos to solution 99599fe
- chore: Linted code for plan-technology-for-your-school.sln solution 1a0e32a
- chore: removed duplicate policies 06202da
- Merge remote-tracking branch 'origin/chore/content-support-merge' into chore/content-support-merge # Conflicts: # sr... c077ddd
- Merge branch 'development' into chore/content-support-merge 6c70dc1
- Removed settings 6bbdb61
- Removed settings fffd470
- Moved content support e2e tests to PT 3dd166d
- Added new e2e tests to spec 97c8331
- updated e2e to point to content/ 5c7e8ac
- cookie update in e2e 5e08e2d
- Removed govuk-visually-hidden from feedback C&S ff6e02d
- Cookie consolidation. E2e tests now using new correct cookies b044672
- fix: update c&s e2e tests 1dbddb9
- Merge branch 'development' into chore/content-support-merge 610c4b5
- update c&s rich text tests 71c713d
- fix: fix sonarcloud issues 5df9dea
- fix table errors 091a231
- fix sonarcloud complaints 77f2993
- Merge branch 'development' into chore/content-support-merge 2f40486
- and 17 more ...