Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
HugoVanLooveren created a review on a pull request on BHoM/ETABS_Toolkit
1. Issue with building it because of missing enum value for GlobalResultType.cs, see comment Peter in [#1639](https://github.com/BHoM/BHoM/pull/1639). 2. Naming convention singular and plural se...
peterjamesnugent created a comment on a pull request on BHoM/ETABS_Toolkit
@HugoVanLooveren you need to build the branch from the core BHoM as per the PR notes: https://github.com/BHoM/BHoM/pull/1639
bhombot-ci[bot] created a comment on a pull request on BHoM/ETABS_Toolkit
<samp>@peterjamesnugent to confirm, the following actions are now queued: - check `versioning` There are 11 requests in the queue ahead of you.</samp>
peterjamesnugent created a comment on a pull request on BHoM/ETABS_Toolkit
@BHoMBot check versioning
HugoVanLooveren created a comment on a pull request on BHoM/ETABS_Toolkit
I tried building the solution and it gave an error: Tried with Beta 7.2 version. Also tried with Alpha 241024 version. ; ```
peterjamesnugent created a review comment on a pull request on BHoM/ETABS_Toolkit
```suggestion case GlobalResultType.StoreyDrifts: ```
peterjamesnugent created a review comment on a pull request on BHoM/ETABS_Toolkit
```suggestion m_model.Results.StoreyDrifts(ref resultCount, ref storyNames, ref loadcaseNames, ref stepType, ref stepNum, ref directions, ref drifts, ref labels, ref x, ref y, ref z); ...
peterjamesnugent created a review comment on a pull request on BHoM/ETABS_Toolkit
```suggestion StoreyDrift stDrft = new StoreyDrift("", loadcaseNames[i], mode, timeStep, storeyNames[i], directions[i], drifts[i]); ``` This will need to reflected on the oM PR.
peterjamesnugent created a review comment on a pull request on BHoM/ETABS_Toolkit
```suggestion storeyDrifts.Add(stDrft); ```
peterjamesnugent created a review comment on a pull request on BHoM/ETABS_Toolkit
Just to confirm the `objectId` parameter is left blank because the results are global and not related to a specific object. The storey will specify the level. ```suggestion Stor...
peterjamesnugent created a review on a pull request on BHoM/ETABS_Toolkit
Some changes relating to the naming - can probably just commit those and get someone to review functionality.
peterjamesnugent created a review on a pull request on BHoM/ETABS_Toolkit
Some changes relating to the naming - can probably just commit those and get someone to review functionality.
peterjamesnugent created a review on a pull request on BHoM/ETABS_Toolkit
Some changes from csproj need to be removed. Otherwise I am happy with the code changes - just @Chrisshort92 to review functionality.
bhombot-ci[bot] created a comment on a pull request on BHoM/ETABS_Toolkit
<samp>@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `nul...
peterjamesnugent created a review comment on a pull request on BHoM/ETABS_Toolkit
As discussed offline, happy that the uneven temperature gradients are accounted for using the `tempDelta` to offset the temperature graidnet (`tempMed`). We can remove the warning about uneven temp...
peterjamesnugent created a review comment on a pull request on BHoM/ETABS_Toolkit
As discussed offline, happy that the uneven temperature gradients are accounted for using the `tempDelta` to offset the temperature graidnet (`tempMed`). We can remove the warning about uneven temp...